🎨 Standard logical FLIP(X)

Author: thinkyhead

Marlin/src/core/macros.h

@@ -80,6 +80,7 @@
 #define CBI32(n,b) (n &= ~_BV32(b))
 #define TBI32(N,B) (N ^= _BV32(B))
 
+// Macros for common maths operations
 #define cu(x)      ({__typeof__(x) _x = (x); (_x)*(_x)*(_x);})
 #define RADIANS(d) ((d)*float(M_PI)/180.0f)
 #define DEGREES(r) ((r)*180.0f/float(M_PI))
@@ -93,6 +94,8 @@
 #define SIGN(a) ({__typeof__(a) _a = (a); (_a>0)-(_a<0);})
 #define IS_POWER_OF_2(x) ((x) && !((x) & ((x) - 1)))
 
+#define FLIP(X) (X = !(X))
+
 // Macros to constrain values
 #ifdef __cplusplus
 

Marlin/src/feature/bedlevel/bedlevel.cpp

@@ -77,7 +77,7 @@ void set_bed_leveling_enabled(const bool enable/*=true*/) {
 
     // Get the corrected leveled / unleveled position
     planner.apply_modifiers(current_position, true);    // Physical position with all modifiers
-    planner.leveling_active ^= true;                    // Toggle leveling between apply and unapply
+    FLIP(planner.leveling_active);                      // Toggle leveling between apply and unapply
     planner.unapply_modifiers(current_position, true);  // Logical position with modifiers removed
 
     sync_plan_position();

Marlin/src/feature/bedlevel/ubl/ubl_G29.cpp

@@ -1607,7 +1607,7 @@ void unified_bed_leveling::smart_fill_mesh() {
         }
 
         if (abort_flag) break;
-        zig_zag ^= true;
+        FLIP(zig_zag);
       }
     }
     probe.stow();

Marlin/src/feature/cooler.h

@@ -40,7 +40,7 @@ class Cooler {
   static bool enabled;
   static void enable()  { enabled = true; }
   static void disable() { enabled = false; }
-  static void toggle()  { enabled = !enabled; }
+  static void toggle()  { FLIP(enabled); }
 
   static uint8_t mode;                  // 0 = CO2 Liquid cooling, 1 = Laser Diode TEC Heatsink Cooling
   static void set_mode(const uint8_t m) { mode = m; }
@@ -96,7 +96,7 @@ class Cooler {
     #if ENABLED(FLOWMETER_SAFETY)
       static bool flowfault;                // Flag that the cooler is in a fault state
       static bool flowsafety_enabled;       // Flag to disable the cutter if flow rate is too low
-      static void flowsafety_toggle()   { flowsafety_enabled = !flowsafety_enabled; }
+      static void flowsafety_toggle()   { FLIP(flowsafety_enabled); }
       static bool check_flow_too_low() {
         const bool too_low = flowsafety_enabled && flowrate < (FLOWMETER_MIN_LITERS_PER_MINUTE);
         flowfault =  too_low;

Marlin/src/feature/fancheck.h

@@ -67,7 +67,7 @@ class FanCheck {
     static void compute_speed(uint16_t elapsedTime);
     static void print_fan_states();
     #if HAS_PWMFANCHECK
-      static void toggle_measuring() { measuring = !measuring; }
+      static void toggle_measuring() { FLIP(measuring); }
       static bool is_measuring() { return measuring; }
     #endif
 

Marlin/src/feature/max7219.cpp

@@ -526,7 +526,7 @@ void Max7219::register_setup() {
         }
         else
           sweepx -= MAX7219_X_LEDS * sweep_dir;
-        patt_on ^= true;
+        FLIP(patt_on);
         next_patt_ms += 100;
         if (++test_mode > 4) test_mode = 0;
       }

Marlin/src/feature/mmu3/SpoolJoin.cpp

@@ -47,7 +47,7 @@ void SpoolJoin::initStatus() {
 
 void SpoolJoin::toggle() {
   // Toggle enabled value.
-  enabled = !enabled;
+  FLIP(enabled);
 
   // Following Prusa's implementation let's save the value to the EEPROM
   // TODO: Move to settings.cpp

Marlin/src/gcode/bedlevel/abl/G29.cpp

@@ -700,7 +700,7 @@ G29_TYPE GcodeSuite::G29() {
           inInc = -1;                   // Zag left
         }
 
-        zig ^= true; // zag
+        FLIP(zig); // zag
 
         // An index to print current state
         grid_count_t pt_index = (PR_OUTER_VAR) * (PR_INNER_SIZE) + 1;

Marlin/src/gcode/calibrate/G33.cpp

@@ -241,7 +241,7 @@ static bool probe_calibration_points(float z_pt[NPP + 1], const int8_t probe_poi
           z_pt[uint8_t(LROUND(rad - interpol + NPP - 1)) % NPP + 1] += z_temp * sq(cos(RADIANS(interpol * 90)));
           z_pt[uint8_t(LROUND(rad - interpol))           % NPP + 1] += z_temp * sq(sin(RADIANS(interpol * 90)));
         }
-        zig_zag = !zig_zag;
+        FLIP(zig_zag);
       }
       if (_7p_intermed_points)
         LOOP_CAL_RAD(rad)

Marlin/src/gcode/calibrate/G34_M422.cpp

@@ -365,7 +365,7 @@ void GcodeSuite::G34() {
             if (decreasing_accuracy(last_z_align_move[zstepper], z_align_abs)) {
               if (DEBUGGING(LEVELING)) DEBUG_ECHOLNPGM("> Z", zstepper + 1, " last_z_align_move = ", last_z_align_move[zstepper]);
               if (DEBUGGING(LEVELING)) DEBUG_ECHOLNPGM("> Z", zstepper + 1, " z_align_abs = ", z_align_abs);
-              adjustment_reverse = !adjustment_reverse;
+              FLIP(adjustment_reverse);
             }
 
             // Remember the alignment for the next iteration, but only if steppers move,