Skip to content

Separate out non-bani bookmarks #1909

@harjot1singh

Description

@harjot1singh

Summary

Bookmarks are pointers to the following types of content:

  • line groups (shabads)
  • banis (compiled collections of lines, orthogonal to sections and sometimes across sources)
  • sources (e.g. sehaj paath of sggs)
  • sections (unsure about this, but thinking of it as a subset of a source. denotes a start and an end line)

Previously, our banis represented a combination of these concepts by repeating the lines. Instead, banis now only should represent compiled collections of lines (e.g. rehraas sahib).

This means banis that are simply pointers to the start and end of an existing source/section should be refactored to be a bookmark of that type.

E.g. Salok M9 bookmark should not be represented by a bani that repeats the lines it contains, but instead, should be a source or section pointer.

This may need some further thought - but the fundamental principal remains

Approach

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    ✓ Type TaskTechnical work that is not directly related to a user requirement but still must be completed.

    Type

    No type

    Projects

    Status

    In Refinement

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions