Skip to content

Commit 6b1c936

Browse files
committed
tune imports
1 parent 9d1f40c commit 6b1c936

File tree

6 files changed

+33
-19
lines changed

6 files changed

+33
-19
lines changed

src/chart.js

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,20 @@ export const Chart = ChartNS;
44
export const plugins = ChartNS.plugins;
55
export const controllers = ChartNS.controllers;
66
export const defaults = ChartNS.defaults;
7-
export const Element = ChartNS.Element;
87
export const helpers = ChartNS.helpers;
9-
export const scaleService = ChartNS.scaleService;
8+
// export const scaleService = ChartNS.scaleService;
9+
10+
// export const DataSetController = ChartNS.DataSetController;
11+
export const BarController = controllers.bar;
12+
export const HorizontalBarController = controllers.horizontalBar;
13+
// export const LineController = controllers.line;
14+
// export const PolarAreaController = controllers.polarArea;
15+
// export const ScatterController = controllers.scatter;
16+
17+
export const Element = ChartNS.Element;
18+
// export const Rectangle = ChartNS.elements.Rectangle;
19+
// export const Point = ChartNS.elements.Point;
20+
// export const Line = ChartNS.elements.Line;
21+
22+
export const merge = ChartNS.helpers.merge;
23+
export const drawPoint = ChartNS.helpers.canvas.drawPoint;

src/controllers/base.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { interpolateNumberArray } from '../animation';
22
import { outlierPositioner, patchInHoveredOutlier } from '../tooltip';
3-
import { controllers } from '../chart';
3+
import { BarController } from '../chart';
44
import { defaultStatsOptions } from '../data';
55

66
export function baseDefaults(keys) {
@@ -46,7 +46,7 @@ export function baseDefaults(keys) {
4646
};
4747
}
4848

49-
export class StatsBase extends controllers.bar {
49+
export class StatsBase extends BarController {
5050
getMinMax(scale, canStack) {
5151
const bak = scale.axis;
5252
const config = this._config;

src/controllers/boxplot.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { asBoxPlotStats } from '../data';
2-
import { Chart, controllers, helpers, defaults } from '../chart';
2+
import { Chart, controllers, defaults, BarController, HorizontalBarController, merge } from '../chart';
33
import { baseDefaults, StatsBase } from './base';
44
import { BoxAndWiskers, boxOptionsKeys } from '../elements';
55
import { patchControllerConfig } from './utils';
@@ -28,11 +28,11 @@ export class BoxPlotController extends StatsBase {
2828
BoxPlotController.id = 'boxplot';
2929
BoxPlotController.register = () => {
3030
BoxPlotController.prototype.dataElementType = BoxAndWiskers.register();
31-
BoxPlotController.prototype.dataElementOptions = controllers.bar.prototype.dataElementOptions.concat(boxOptionsKeys);
31+
BoxPlotController.prototype.dataElementOptions = BarController.prototype.dataElementOptions.concat(boxOptionsKeys);
3232

3333
defaults.set(
3434
BoxPlotController.id,
35-
helpers.merge({}, [
35+
merge({}, [
3636
defaults.bar,
3737
baseDefaults(boxOptionsKeys),
3838
{
@@ -73,13 +73,13 @@ export class HorizontalBoxPlotController extends BoxPlotController {
7373
HorizontalBoxPlotController.id = 'horizontalBoxplot';
7474
HorizontalBoxPlotController.register = () => {
7575
HorizontalBoxPlotController.prototype.dataElementType = BoxAndWiskers.register();
76-
HorizontalBoxPlotController.prototype.dataElementOptions = controllers.horizontalBar.prototype.dataElementOptions.concat(
76+
HorizontalBoxPlotController.prototype.dataElementOptions = HorizontalBarController.prototype.dataElementOptions.concat(
7777
boxOptionsKeys
7878
);
7979

8080
defaults.set(
8181
HorizontalBoxPlotController.id,
82-
helpers.merge({}, [
82+
merge({}, [
8383
defaults.horizontalBar,
8484
baseDefaults(boxOptionsKeys),
8585
{

src/controllers/violin.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { asViolinStats } from '../data';
2-
import { Chart, controllers, defaults, helpers } from '../chart';
2+
import { Chart, controllers, defaults, helpers, BarController, HorizontalBarController } from '../chart';
33
import { StatsBase, baseDefaults } from './base';
44
import { baseOptionKeys } from '../elements/base';
55
import { ViolinElement } from '../elements';
@@ -34,7 +34,7 @@ export class ViolinController extends StatsBase {
3434
ViolinController.id = 'violin';
3535
ViolinController.register = () => {
3636
ViolinController.prototype.dataElementType = ViolinElement.register();
37-
ViolinController.prototype.dataElementOptions = controllers.bar.prototype.dataElementOptions.concat(baseOptionKeys);
37+
ViolinController.prototype.dataElementOptions = BarController.prototype.dataElementOptions.concat(baseOptionKeys);
3838

3939
defaults.set(
4040
ViolinController.id,
@@ -84,7 +84,7 @@ export class HorizontalViolinController extends ViolinController {
8484
HorizontalViolinController.id = 'horizontalViolin';
8585
HorizontalViolinController.register = () => {
8686
HorizontalViolinController.prototype.dataElementType = ViolinElement.register();
87-
HorizontalViolinController.prototype.dataElementOptions = controllers.horizontalBar.prototype.dataElementOptions.concat(
87+
HorizontalViolinController.prototype.dataElementOptions = HorizontalViolinController.prototype.dataElementOptions.concat(
8888
baseOptionKeys
8989
);
9090

src/elements/base.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { defaults, Element, helpers } from '../chart';
1+
import { defaults, Element, drawPoint } from '../chart';
22
import { rnd } from '../data';
33

44
export const baseDefaults = {
@@ -51,11 +51,11 @@ export class StatsBase extends Element {
5151

5252
if (vert) {
5353
props.items.forEach((v) => {
54-
helpers.canvas.drawPoint(ctx, pointOptions, props.x - props.width / 2 + random() * props.width, v);
54+
drawPoint(ctx, pointOptions, props.x - props.width / 2 + random() * props.width, v);
5555
});
5656
} else {
5757
props.items.forEach((v) => {
58-
helpers.canvas.drawPoint(ctx, pointOptions, v, props.y - props.height / 2 + random() * props.height);
58+
drawPoint(ctx, pointOptions, v, props.y - props.height / 2 + random() * props.height);
5959
});
6060
}
6161
ctx.restore();
@@ -81,11 +81,11 @@ export class StatsBase extends Element {
8181

8282
if (vert) {
8383
props.outliers.forEach((v) => {
84-
helpers.canvas.drawPoint(ctx, pointOptions, props.x, v);
84+
drawPoint(ctx, pointOptions, props.x, v);
8585
});
8686
} else {
8787
props.outliers.forEach((v) => {
88-
helpers.canvas.drawPoint(ctx, pointOptions, v, props.y);
88+
drawPoint(ctx, pointOptions, v, props.y);
8989
});
9090
}
9191

src/elements/violin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { helpers, defaults } from '../chart';
1+
import { defaults, drawPoint } from '../chart';
22
import { StatsBase, baseDefaults } from './base';
33

44
export class ViolinElement extends StatsBase {
@@ -11,7 +11,7 @@ export class ViolinElement extends StatsBase {
1111

1212
const props = this.getProps(['x', 'y', 'width', 'height', 'min', 'max', 'coords', 'maxEstimate']);
1313

14-
helpers.canvas.drawPoint(
14+
drawPoint(
1515
ctx,
1616
{
1717
pointStyle: 'rectRot',

0 commit comments

Comments
 (0)