feat: use airbnb style

Author: sgratzl

.eslintrc.js

@@ -5,15 +5,26 @@ const pkg = require('./package.json');
 
 module.exports = {
   plugins: ['@typescript-eslint', 'prettier'],
-  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'plugin:prettier/recommended', 'prettier'],
+  extends: [
+    'airbnb-typescript',
+    'react-app',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:prettier/recommended',
+    'prettier',
+  ],
+  parserOptions: {
+    project: './tsconfig.eslint.json',
+  },
   settings: {
     react: {
       version: pkg.devDependencies.react ? 'detect' : '99.99.99',
     },
   },
   rules: {
-    '@typescript-eslint/explicit-module-boundary-types': 'off',
+    // '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-non-null-assertion': 'off',
+    'no-underscore-dangle': 'off',
+    'max-classes-per-file': 'off',
+    // '@typescript-eslint/no-non-null-assertion': 'off',
   },
 };

.vscode/settings.json

@@ -13,7 +13,6 @@
   "[yaml]": {
     "editor.defaultFormatter": "esbenp.prettier-vscode"
   },
-  "prettier.packageManager": "yarn",
   "eslint.packageManager": "yarn",
   "npm.packageManager": "yarn",
   "eslint.nodePath": ".yarn/sdks",
@@ -26,5 +25,5 @@
   "search.exclude": {
     "**/.yarn": true,
     "**/.pnp.*": true
-  }
+  },
 }

.yarnrc_patch.yml

@@ -1 +1,4 @@
-# packageExtensions:
+packageExtensions:
+  eslint-module-utils@*:
+    dependencies:
+      eslint-import-resolver-node: '*'

package.json

@@ -75,6 +75,7 @@
     "canvas-5-polyfill": "^0.1.5",
     "chart.js": "^3.0.0-rc",
     "eslint": "^7.22.0",
+    "eslint-config-airbnb-typescript": "^12.3.1",
     "eslint-config-prettier": "^8.1.0",
     "eslint-config-react-app": "^6.0.0",
     "eslint-plugin-flowtype": "^5.4.0",

src/__tests__/createChart.ts

@@ -17,7 +17,7 @@ function toBuffer(canvas: HTMLCanvasElement) {
   });
 }
 
-export async function expectMatchSnapshot(canvas: HTMLCanvasElement) {
+export async function expectMatchSnapshot(canvas: HTMLCanvasElement): Promise<void> {
   const image = await toBuffer(canvas);
   expect(image).toMatchImageSnapshot();
 }
@@ -32,21 +32,19 @@ export default function createChart<
   canvas.height = height;
   defaults.font.family = 'Courier New';
   defaults.color = 'transparent';
-  config.options = Object.assign(
-    {
-      responsive: false,
-      animation: false,
-      plugins: {
-        legend: {
-          display: false,
-        },
-        title: {
-          display: false,
-        },
+  config.options = {
+    responsive: false,
+    animation: false,
+    plugins: {
+      legend: {
+        display: false,
+      },
+      title: {
+        display: false,
       },
     },
-    config.options || {}
-  ) as any;
+    ...(config.options || {}),
+  } as any;
   const ctx = canvas.getContext('2d')!;
 
   const t = new Chart<TYPE, DATA, LABEL>(ctx, config);

src/animation.ts

@@ -15,7 +15,11 @@ const interpolators = {
   },
 };
 
-export function interpolateNumberArray(from: number | number[], to: number | number[], factor: number) {
+export function interpolateNumberArray(
+  from: number | number[],
+  to: number | number[],
+  factor: number
+): number | null | undefined | (number | null | undefined)[] {
   if (typeof from === 'number' && typeof to === 'number') {
     return interpolators.number(from, to, factor);
   }
@@ -25,7 +29,11 @@ export function interpolateNumberArray(from: number | number[], to: number | num
   return to;
 }
 
-export function interpolateKdeCoords(from: IKDEPoint[], to: IKDEPoint[], factor: number) {
+export function interpolateKdeCoords(
+  from: IKDEPoint[],
+  to: IKDEPoint[],
+  factor: number
+): { v: number | null | undefined; estimate: number | null | undefined }[] {
   if (Array.isArray(from) && Array.isArray(to)) {
     return to.map((t, i) => ({
       v: interpolators.number(from[i] ? from[i].v : null, t.v, factor),

src/controllers/BoxPlotController.spec.ts

@@ -1,7 +1,7 @@
+import { registry, BarController, LineController, PointElement, BarElement, LineElement } from 'chart.js';
 import createChart from '../__tests__/createChart';
 import { BoxPlotController, BoxPlotDataPoint } from './BoxPlotController';
 import { Samples } from './__tests__/utils';
-import { registry, BarController, LineController, PointElement, BarElement, LineElement } from 'chart.js';
 import { BoxAndWiskers } from '../elements';
 
 const options = {

src/controllers/BoxPlotController.ts

@@ -1,5 +1,4 @@
-import { asBoxPlotStats, IBaseStats, IBoxPlot, IBoxplotOptions } from '../data';
-import {
+import {
   Chart,
   BarController,
   ControllerDatasetOptions,
@@ -12,25 +11,27 @@ import {
   CartesianScaleTypeRegistry,
 } from 'chart.js';
 import { merge } from 'chart.js/helpers';
+import { asBoxPlotStats, IBaseStats, IBoxPlot, IBoxplotOptions } from '../data';
 import { baseDefaults, StatsBase, defaultOverrides } from './base';
 import { BoxAndWiskers, IBoxAndWhiskersOptions } from '../elements';
 import patchController from './patchController';
 import { boxOptionsKeys } from '../elements/BoxAndWiskers';
 
 export class BoxPlotController extends StatsBase<IBoxPlot, Required<IBoxplotOptions>> {
-  protected _parseStats(value: any, config: IBoxplotOptions) {
+  protected _parseStats(value: unknown, config: IBoxplotOptions): IBoxPlot | undefined {
     return asBoxPlotStats(value, config);
   }
 
-  protected _transformStats<T>(target: any, source: IBoxPlot, mapper: (v: number) => T) {
+  protected _transformStats<T>(target: any, source: IBoxPlot, mapper: (v: number) => T): void {
     super._transformStats(target, source, mapper);
     for (const key of ['whiskerMin', 'whiskerMax']) {
       target[key] = mapper(source[key as 'whiskerMin' | 'whiskerMax']);
     }
   }
 
   static readonly id = 'boxplot';
-  static readonly defaults: any = /*#__PURE__*/ merge({}, [
+
+  static readonly defaults: any = /* #__PURE__ */ merge({}, [
     BarController.defaults,
     baseDefaults(boxOptionsKeys),
     {
@@ -46,7 +47,8 @@ export class BoxPlotController extends StatsBase<IBoxPlot, Required<IBoxplotOpti
       dataElementType: BoxAndWiskers.id,
     },
   ]);
-  static readonly overrides: any = /*#__PURE__*/ merge({}, [(BarController as any).overrides, defaultOverrides()]);
+
+  static readonly overrides: any = /* #__PURE__ */ merge({}, [(BarController as any).overrides, defaultOverrides()]);
 }
 
 export interface BoxPlotControllerDatasetOptions

src/controllers/ViolinController.spec.ts

@@ -1,7 +1,7 @@
+import { registry } from 'chart.js';
 import createChart from '../__tests__/createChart';
 import { ViolinController } from './ViolinController';
 import { Samples } from './__tests__/utils';
-import { registry } from 'chart.js';
 import { Violin } from '../elements';
 
 describe('violin', () => {

src/controllers/ViolinController.ts

@@ -1,5 +1,4 @@
-import { asViolinStats, IBaseStats, IViolin, IViolinOptions } from '../data';
-import {
+import {
   Chart,
   BarController,
   ChartItem,
@@ -12,6 +11,7 @@ import {
   CartesianScaleTypeRegistry,
 } from 'chart.js';
 import { merge } from 'chart.js/helpers';
+import { asViolinStats, IBaseStats, IViolin, IViolinOptions } from '../data';
 import { StatsBase, baseDefaults, defaultOverrides } from './base';
 import { baseOptionKeys } from '../elements/base';
 import { IViolinElementOptions, Violin } from '../elements';
@@ -27,12 +27,13 @@ export class ViolinController extends StatsBase<IViolin, Required<IViolinOptions
     super._transformStats(target, source, mapper);
     target.maxEstimate = source.maxEstimate;
     if (Array.isArray(source.coords)) {
-      target.coords = source.coords.map((c) => Object.assign({}, c, { v: mapper(c.v) }));
+      target.coords = source.coords.map((c) => ({ ...c, v: mapper(c.v) }));
     }
   }
 
   static readonly id = 'violin';
-  static readonly defaults: any = /*#__PURE__*/ merge({}, [
+
+  static readonly defaults: any = /* #__PURE__ */ merge({}, [
     BarController.defaults,
     baseDefaults(baseOptionKeys),
     {
@@ -53,7 +54,8 @@ export class ViolinController extends StatsBase<IViolin, Required<IViolinOptions
       dataElementType: Violin.id,
     },
   ]);
-  static readonly overrides: any = /*#__PURE__*/ merge({}, [(BarController as any).overrides, defaultOverrides()]);
+
+  static readonly overrides: any = /* #__PURE__ */ merge({}, [(BarController as any).overrides, defaultOverrides()]);
 }
 export type ViolinDataPoint = number[] | (Partial<IViolin> & IBaseStats);