Skip to content

Commit 362099a

Browse files
authored
chore: delete lint command (electron#2964)
1 parent 6b215b0 commit 362099a

File tree

4 files changed

+4
-96
lines changed

4 files changed

+4
-96
lines changed

packages/api/cli/src/electron-forge-lint.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

packages/api/core/src/api/index.ts

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { ElectronProcess, ForgeMakeResult } from '@electron-forge/shared-types';
22

33
import _import, { ImportOptions } from './import';
44
import init, { InitOptions } from './init';
5-
import lint, { LintOptions } from './lint';
65
import make, { MakeOptions } from './make';
76
import _package, { PackageOptions } from './package';
87
import publish, { PublishOptions } from './publish';
@@ -28,16 +27,6 @@ export class ForgeAPI {
2827
return init(opts);
2928
}
3029

31-
/**
32-
* Lint a local Electron application.
33-
*
34-
* The promise will be rejected with the stdout+stderr of the linting process
35-
* if linting fails or will be resolved if it succeeds.
36-
*/
37-
lint(opts: LintOptions): Promise<void> {
38-
return lint(opts);
39-
}
40-
4130
/**
4231
* Make distributables for an Electron application
4332
*/
@@ -72,17 +61,4 @@ export class ForgeAPI {
7261
const api = new ForgeAPI();
7362
const utils = new ForgeUtils();
7463

75-
export {
76-
ForgeMakeResult,
77-
ElectronProcess,
78-
ForgeUtils,
79-
ImportOptions,
80-
InitOptions,
81-
LintOptions,
82-
MakeOptions,
83-
PackageOptions,
84-
PublishOptions,
85-
StartOptions,
86-
api,
87-
utils,
88-
};
64+
export { ForgeMakeResult, ElectronProcess, ForgeUtils, ImportOptions, InitOptions, MakeOptions, PackageOptions, PublishOptions, StartOptions, api, utils };

packages/api/core/src/api/lint.ts

Lines changed: 0 additions & 44 deletions
This file was deleted.

packages/api/core/test/slow/api_spec_slow.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { createDefaultCertificate } from '@electron-forge/maker-appx';
2-
import { ensureTestDirIsNonexistent, expectProjectPathExists } from '@electron-forge/test-utils';
2+
import { ensureTestDirIsNonexistent, expectLintToPass, expectProjectPathExists } from '@electron-forge/test-utils';
33
import { execSync } from 'child_process';
44
import { expect } from 'chai';
55
import { ForgeConfig, IForgeResolvableMaker } from '@electron-forge/shared-types';
@@ -78,7 +78,7 @@ for (const nodeInstaller of ['npm', 'yarn']) {
7878
});
7979

8080
describe('lint', () => {
81-
it('should initially pass the linting process', () => forge.lint({ dir }));
81+
it('should initially pass the linting process', () => expectLintToPass(dir));
8282
});
8383

8484
after(() => fs.remove(dir));
@@ -116,7 +116,7 @@ for (const nodeInstaller of ['npm', 'yarn']) {
116116
});
117117

118118
describe('lint', () => {
119-
it('should initially pass the linting process', () => forge.lint({ dir }));
119+
it('should initially pass the linting process', () => expectLintToPass(dir));
120120
});
121121

122122
after(async () => {

0 commit comments

Comments
 (0)