fix a bunch of clippy warnings

Author: LorenzSchueler

src/lib.rs

@@ -178,7 +178,7 @@ pub trait StreamingIterator {
         Self: Sized,
         F: FnMut(&Self::Item) -> bool,
     {
-        Filter { it: self, f: f }
+        Filter { it: self, f }
     }
 
     /// Creates an iterator which both filters and maps by applying a closure to elements.
@@ -190,7 +190,7 @@ pub trait StreamingIterator {
     {
         FilterMap {
             it: self,
-            f: f,
+            f,
             item: None,
         }
     }
@@ -280,7 +280,7 @@ pub trait StreamingIterator {
     {
         Map {
             it: self,
-            f: f,
+            f,
             item: None,
         }
     }
@@ -308,7 +308,7 @@ pub trait StreamingIterator {
         Self: Sized,
         F: Fn(&Self::Item) -> &B,
     {
-        MapRef { it: self, f: f }
+        MapRef { it: self, f }
     }
 
     /// Consumes the first `n` elements of the iterator, returning the next one.
@@ -362,7 +362,7 @@ pub trait StreamingIterator {
     where
         Self: Sized,
     {
-        Skip { it: self, n: n }
+        Skip { it: self, n }
     }
 
     /// Creates an iterator that skips initial elements matching a predicate.
@@ -374,7 +374,7 @@ pub trait StreamingIterator {
     {
         SkipWhile {
             it: self,
-            f: f,
+            f,
             done: false,
         }
     }
@@ -387,7 +387,7 @@ pub trait StreamingIterator {
     {
         Take {
             it: self,
-            n: n,
+            n,
             done: false,
         }
     }
@@ -401,7 +401,7 @@ pub trait StreamingIterator {
     {
         TakeWhile {
             it: self,
-            f: f,
+            f,
             done: false,
         }
     }
@@ -1970,7 +1970,7 @@ where
     {
         if self.n > 0 {
             // nth(n) skips n+1
-            if let None = self.it.nth(self.n - 1) {
+            if self.it.nth(self.n - 1).is_none() {
                 return init;
             }
         }
@@ -1994,7 +1994,7 @@ where
     {
         if self.n > 0 {
             // nth(n) skips n+1
-            if let None = self.it.nth(self.n - 1) {
+            if self.it.nth(self.n - 1).is_none() {
                 return init;
             }
         }

src/sources.rs

@@ -337,12 +337,12 @@ where
     }
 
     #[inline]
-    fn fold<Acc, Fold>(self, init: Acc, mut f: Fold) -> Acc
+    fn fold<Acc, Fold>(self, init: Acc, f: Fold) -> Acc
     where
         Self: Sized,
         Fold: FnMut(Acc, &Self::Item) -> Acc,
     {
-        self.it.fold(init, move |acc, item| f(acc, item))
+        self.it.fold(init, f)
     }
 }
 
@@ -356,12 +356,12 @@ where
     }
 
     #[inline]
-    fn rfold<Acc, Fold>(self, init: Acc, mut f: Fold) -> Acc
+    fn rfold<Acc, Fold>(self, init: Acc, f: Fold) -> Acc
     where
         Self: Sized,
         Fold: FnMut(Acc, &Self::Item) -> Acc,
     {
-        self.it.rev().fold(init, move |acc, item| f(acc, item))
+        self.it.rev().fold(init, f)
     }
 }
 
@@ -447,12 +447,12 @@ where
     }
 
     #[inline]
-    fn fold_mut<B, F>(self, init: B, mut f: F) -> B
+    fn fold_mut<B, F>(self, init: B, f: F) -> B
     where
         Self: Sized,
         F: FnMut(B, &mut Self::Item) -> B,
     {
-        self.it.fold(init, move |acc, item| f(acc, item))
+        self.it.fold(init, f)
     }
 }
 
@@ -461,12 +461,12 @@ where
     I: DoubleEndedIterator<Item = &'a mut T>,
 {
     #[inline]
-    fn rfold_mut<B, F>(self, init: B, mut f: F) -> B
+    fn rfold_mut<B, F>(self, init: B, f: F) -> B
     where
         Self: Sized,
         F: FnMut(B, &mut Self::Item) -> B,
     {
-        self.it.rev().fold(init, move |acc, item| f(acc, item))
+        self.it.rev().fold(init, f)
     }
 }
 
@@ -594,10 +594,7 @@ impl<T, F: FnOnce() -> T> StreamingIterator for OnceWith<T, F> {
 
     #[inline]
     fn advance(&mut self) {
-        self.item = match self.gen.take() {
-            Some(gen) => Some(gen()),
-            None => None,
-        };
+        self.item = self.gen.take().map(|gen| gen());
     }
 
     #[inline]