linted, new iobroker tests

Author: sestriel

eslint.config.mjs

@@ -1,44 +1,35 @@
-import globals from "globals";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-import js from "@eslint/js";
-import { FlatCompat } from "@eslint/eslintrc";
+import config from '@iobroker/eslint-config';
 
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-const compat = new FlatCompat({
-    baseDirectory: __dirname,
-    recommendedConfig: js.configs.recommended,
-    allConfig: js.configs.all
-});
+export default [
+    ...config,
 
-export default [{
-    ignores: ["admin/blockly.js", "**/.eslintrc.js", "admin/words.js", "node_modules", ".*"],
-}, ...compat.extends("eslint:recommended"), {
-    languageOptions: {
-        globals: {
-            ...globals.node,
-            ...globals.mocha,
-        },
-
-        ecmaVersion: 2022,
-        sourceType: "commonjs",
+    {
+        // specify files to exclude from linting here
+        ignores: [
+            '.dev-server/',
+            '.vscode/',
+            '**/*.test.js',
+            'test/**/*.js',
+            '*.config.mjs',
+            'build',
+            'admin/build',
+            'admin/words.js',
+            'admin/blockly.js',
+            'admin/admin.d.ts',
+            '**/adapter-config.d.ts',
+            'lib/words.js',
+            'admin/custom',
+            'admin/rules',
+            'src/', // TODO
+            'src-admin/', // TODO
+        ]
     },
-
-    rules: {
-        indent: ["error", 4, {
-            SwitchCase: 1,
-        }],
-
-        "no-console": "off",
-        "no-var": "error",
-        "prefer-const": "error",
-
-        quotes: ["error", "double", {
-            avoidEscape: true,
-            allowTemplateLiterals: true,
-        }],
-
-        semi: ["error", "always"],
+    {
+        rules: {
+            'jsdoc/require-jsdoc': 'off',
+            'jsdoc/require-param-description': 'off',
+            'jsdoc/require-returns-description': 'off',
+            'jsdoc/require-returns-check': 'off',
+        },
     },
-}];
+];

lib/actionButton.js

@@ -1,82 +1,74 @@
 "use strict";
 
-class ActionButton
-{
-    constructor(action, label, clear = false)
-    {
-        this.action = action;
-        this.label  = label;
-        this.clear  = clear;
-    }
+class ActionButton {
+  constructor(action, label, clear = false) {
+    this.action = action;
+    this.label = label;
+    this.clear = clear;
+  }
 
-    isValidUrl(urlString)
-    {
-        const urlPattern = new RegExp("^(https?:\\/\\/)?"+ // validate protocol
-        "((([a-z\\d]([a-z\\d-]*[a-z\\d])*)\\.)+[a-z]{2,}|"+ // validate domain name
-        "((\\d{1,3}\\.){3}\\d{1,3}))"+ // validate OR ip (v4) address
-        "(\\:\\d+)?(\\/[-a-z\\d%_.~+]*)*"+ // validate port and path
-        "(\\?[;&a-z\\d%_.~+=-]*)?"+ // validate query string
-        "(\\#[-a-z\\d_]*)?$","i"); // validate fragment locator
-        return !!urlPattern.test(urlString);
-    }
+  isValidUrl(urlString) {
+    const urlPattern = new RegExp(
+      "^(https?:\\/\\/)?" + // validate protocol
+        "((([a-z\\d]([a-z\\d-]*[a-z\\d])*)\\.)+[a-z]{2,}|" + // validate domain name
+        "((\\d{1,3}\\.){3}\\d{1,3}))" + // validate OR ip (v4) address
+        "(\\:\\d+)?(\\/[-a-z\\d%_.~+]*)*" + // validate port and path
+        "(\\?[;&a-z\\d%_.~+=-]*)?" + // validate query string
+        "(\\#[-a-z\\d_]*)?$",
+      "i",
+    ); // validate fragment locator
+    return !!urlPattern.test(urlString);
+  }
 }
 
-class ActionButtonView extends ActionButton
-{
-    constructor(label, url, clear = false)
-    {
-        super("view", label, clear);
-
-        this.url = url;
-    }
+class ActionButtonView extends ActionButton {
+  constructor(label, url, clear = false) {
+    super("view", label, clear);
 
+    this.url = url;
+  }
 }
 
-class ActionButtonHTTP extends ActionButton
-{
-    constructor(label, url, clear = false)
-    {
-        super("http", label, clear);
-
-        this.url = url;
-        this.method = "POST";
-        this.headers = {};
-        this.body = "";
-    }
+class ActionButtonHTTP extends ActionButton {
+  constructor(label, url, clear = false) {
+    super("http", label, clear);
 
-    getData()
-    {
-        return {
-            action: this.action,
-            label: this.label,
-            url: this.url,
-            method: this.method,
-            headers: this.headers,
-            body: this.body,
-            clear: this.clear
-        };
-    }
+    this.url = url;
+    this.method = "POST";
+    this.headers = {};
+    this.body = "";
+  }
 
-    setMethod(method)
-    {
-        this.method = method;
-    }
+  getData() {
+    return {
+      action: this.action,
+      label: this.label,
+      url: this.url,
+      method: this.method,
+      headers: this.headers,
+      body: this.body,
+      clear: this.clear,
+    };
+  }
 
-    setHeaders(headers)
-    {
-        this.headers = headers;
-    }
-
-    setBody(body)
-    {
-        this.body = body;
-    }
-}
+  setMethod(method) {
+    this.method = method;
+  }
 
-class ActionButtonAB extends ActionButton
-{
+  setHeaders(headers) {
+    this.headers = headers;
+  }
 
+  setBody(body) {
+    this.body = body;
+  }
 }
 
+class ActionButtonAB extends ActionButton {}
 
-module.exports = { ActionButton, ActionButtonView, ActionButtonHTTP, ActionButtonAB };
+module.exports = {
+  ActionButton,
+  ActionButtonView,
+  ActionButtonHTTP,
+  ActionButtonAB,
+};