You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 20, 2024. It is now read-only.
After updating bors to the latest master in the rust-lang/rust repository, we saw afewproblems:
Users in the reviewers list could post comments without any problem
Users in the try list received a "you're not a reviewer" message
Normal users received both "you're not a reviewer" and "you can't use try" messages
I think the cause of that is #149. Before that PR, the verify_auth calls were "configured" at the start of process_command and then called when they were actually needed. Instead, now the verify_auth calls are directly executed at the start of process_command, which means bors check if the user is a reviewer even if they send a simple comment without any command.
The simple solution to this issue is to reintroduce functools.partial in auth checks.