Skip to content

Extremely slow workflow details view #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JBBianchi opened this issue May 10, 2022 · 7 comments
Closed

Extremely slow workflow details view #77

JBBianchi opened this issue May 10, 2022 · 7 comments
Assignees
Labels
priority: high Indicates a high priority issue type: enhancement New feature or request weight: 3 An issue with an average development impact

Comments

@JBBianchi
Copy link
Member

What happened:
After starting multiple instances, going to the workflow definitions' list and coming back to a workflow detail, the list of instances/graph takes multiple seconds to display!

What you expected to happen:
To be way faster

@JBBianchi JBBianchi added type: enhancement New feature or request priority: high Indicates a high priority issue app: dashboard Concerns the Dashboard UI weight: 3 An issue with an average development impact labels May 10, 2022
@JBBianchi JBBianchi added this to the 0.2.0 milestone May 10, 2022
@JBBianchi JBBianchi self-assigned this May 10, 2022
@JBBianchi
Copy link
Member Author

@cdavernas > Could it be a deserialization issue ? Making the request is quite fast but it takes a lot of time for the result variable to be assigned.

serialization

@JBBianchi JBBianchi added app: api Concerns the API and removed app: dashboard Concerns the Dashboard UI app: api Concerns the API labels May 10, 2022
@cdavernas
Copy link
Member

@JBBianchi What about performances when debug/remote debug (Blazor) is disabled? Still unsatisfying?
In addition, are you using persistence plugins?

@JBBianchi
Copy link
Member Author

@cdavernas no persistence, I don't think it have anything to do with debugging. It's await this.Serializer.DeserializeAsync<List>(json, cancellationToken) in the api client that hangs.

@cdavernas
Copy link
Member

@JBBianchi I think it's due to the Dynamic implementation, which is very bad news 😭

@cdavernas cdavernas modified the milestones: v0.2.0, v0.3.0 Sep 26, 2022
@cdavernas cdavernas removed this from the v0.3.0 milestone Nov 4, 2022
@cdavernas
Copy link
Member

@JBBianchi Hasn't this been fixed, aside from Dynamic issue (which will be solved with .NET 7 and replacement of Newtonsoft)?

@JBBianchi
Copy link
Member Author

@cdavernas the issue is still present to my knowledge. 🤞 for it to be solved with .NET 7 and System.Text.

@cdavernas
Copy link
Member

cdavernas commented May 26, 2024

Fixed the issue in #366.

Minor improvements involved serialization optimization, achieved mainly by switching to System.Text.Json and eliminating types like Dynamic. The major fix addressed design flaws: the API's workflow instance metadata included the workflow input/output for every activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Indicates a high priority issue type: enhancement New feature or request weight: 3 An issue with an average development impact
Projects
None yet
Development

No branches or pull requests

2 participants