Skip to content

Commit f391e71

Browse files
authored
fix(triggers): support disable mps by unbind (#169)
* fix(triggers): support disable mps by unbind * ci: update test step title
1 parent da03ea4 commit f391e71

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
run: |
3939
npm update --no-save
4040
npm update --save-dev --no-save
41-
- name: Running integration tests
41+
- name: Running tests
4242
run: npm run test
4343
env:
4444
TENCENT_SECRET_ID: ${{ secrets.TENCENT_SECRET_ID }}

src/modules/triggers/base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,6 @@ const TRIGGER_STATUS_MAP = {
7474
0: 'CLOSE',
7575
};
7676

77-
const CAN_UPDATE_TRIGGER = ['apigw', 'cls'];
77+
const CAN_UPDATE_TRIGGER = ['apigw', 'cls', 'mps'];
7878

7979
module.exports = { BaseTrigger, TRIGGER_STATUS_MAP, CAN_UPDATE_TRIGGER };

src/modules/triggers/mps.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const { MPS } = require('./apis');
22
const { camelCaseProperty } = require('../../utils/index');
3-
const { BaseTrigger, TRIGGER_STATUS_MAP } = require('./base');
3+
const { BaseTrigger } = require('./base');
44

55
class MpsTrigger extends BaseTrigger {
66
async request({ Action, ...data }) {
@@ -9,15 +9,13 @@ class MpsTrigger extends BaseTrigger {
99
}
1010

1111
getKey(triggerInputs) {
12-
const Enable = TRIGGER_STATUS_MAP[triggerInputs.Enable];
13-
1412
if (triggerInputs.ResourceId) {
1513
// from ListTriggers API
1614
const rStrArr = triggerInputs.ResourceId.split('/');
17-
return `${rStrArr[rStrArr.length - 1]}-${Enable}`;
15+
return `${rStrArr[rStrArr.length - 1]}`;
1816
}
1917

20-
return `${triggerInputs.TriggerDesc.eventType}Event-${Enable}`;
18+
return `${triggerInputs.TriggerDesc.eventType}Event`;
2119
}
2220

2321
formatInputs({ inputs }) {

0 commit comments

Comments
 (0)