Skip to content

Commit d43d499

Browse files
author
Aleksander Dikanski
committed
Fix eslint warnings
1 parent 6b173d4 commit d43d499

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

lib/stackInformation.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -171,16 +171,14 @@ module.exports = {
171171
BbPromise.bind(this).then(this.aliasStackLoadAliasTemplates)
172172
)
173173
.spread((currentTemplate, aliasStackTemplates) => {
174+
const filteredAliasStackTemplates = _.without(aliasStackTemplates, ['stack', `${this._provider.naming.getStackName()}-${this._alias}`]);
174175
const currentAliasStackTemplate =
175-
_.get(
176-
_.first(_.remove(aliasStackTemplates, ['stack', `${this._provider.naming.getStackName()}-${this._alias}`])),
177-
'template',
178-
{});
179-
const deployedAliasStackTemplates = _.map(aliasStackTemplates, template => template.template);
176+
_.get(_.first(filteredAliasStackTemplates, 'template', {}));
177+
const deployedAliasStackTemplates = _.map(filteredAliasStackTemplates, template => template.template);
180178

181179
this._serverless.service.provider.deployedCloudFormationTemplate = currentTemplate;
182180
this._serverless.service.provider.deployedCloudFormationAliasTemplate = currentAliasStackTemplate;
183-
this._serverless.service.provider.deployedAliasTemplates = aliasStackTemplates;
181+
this._serverless.service.provider.deployedAliasTemplates = filteredAliasStackTemplates;
184182
return BbPromise.resolve([ currentTemplate, deployedAliasStackTemplates, currentAliasStackTemplate ]);
185183
});
186184
},

lib/stackops/apiGateway.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ module.exports = function(currentTemplate, aliasStackTemplates, currentAliasStac
265265
if (_.isString(resource.DependsOn) && resource.DependsOn === name) {
266266
resource.DependsOn = aliasedName;
267267
} else if (_.isArray(resource.DependsOn) && _.includes(resource.DependsOn, name)) {
268-
_.pull(resource.DependsOn, name);
268+
resource.DependsOn = _.without(resource.DependsOn, name);
269269
resource.DependsOn.push(aliasedName);
270270
}
271271
});

0 commit comments

Comments
 (0)