Merge pull request #427 from serilog/xunit

nblumhardt · web-flow · commit d9ddc3920554 · 2024-07-12T07:18:25.000+10:00
Update xunit to 2.9.0
diff --git a/test/Serilog.Settings.Configuration.Tests/ConfigurationSettingsTests.cs b/test/Serilog.Settings.Configuration.Tests/ConfigurationSettingsTests.cs
@@ -60,7 +60,7 @@ public void PropertyEnrichmentIsApplied()
     [Theory]
     [InlineData(null)]
     [InlineData("")]
-    public void CanReadWithoutSerilogSection(string sectionName)
+    public void CanReadWithoutSerilogSection(string? sectionName)
     {
         LogEvent? evt = null;
 
diff --git a/test/Serilog.Settings.Configuration.Tests/Serilog.Settings.Configuration.Tests.csproj b/test/Serilog.Settings.Configuration.Tests/Serilog.Settings.Configuration.Tests.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT'">net48</TargetFrameworks>
@@ -25,7 +25,7 @@
     <PackageReference Include="NuGet.Frameworks" Version="6.7.0" />
     <PackageReference Include="Polly" Version="8.2.0" />
     <PackageReference Include="Serilog.Expressions" Version="4.0.0" />
-    <PackageReference Include="xunit" Version="2.5.3" />
+    <PackageReference Include="xunit" Version="2.9.0" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.5.3" />
     <PackageReference Include="Shouldly" Version="4.2.1" />
     <PackageReference Include="PublicApiGenerator" Version="11.0.0" />
diff --git a/test/Serilog.Settings.Configuration.Tests/StringArgumentValueTests.cs b/test/Serilog.Settings.Configuration.Tests/StringArgumentValueTests.cs
@@ -54,7 +54,7 @@ public void StringValuesConvertToDefaultInstancesIfTargetIsAbstractClass()
     // a full-qualified type name should not be considered a static member accessor
     [InlineData("My.NameSpace.Class, MyAssembly, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089",
        null, null)]
-    public void TryParseStaticMemberAccessorReturnsExpectedResults(string input, string? expectedAccessorType, string expectedPropertyName)
+    public void TryParseStaticMemberAccessorReturnsExpectedResults(string? input, string? expectedAccessorType, string? expectedPropertyName)
     {
         var actual = StringArgumentValue.TryParseStaticMemberAccessor(input,
             out var actualAccessorType,

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public void PropertyEnrichmentIsApplied()`
`60`	`60`	`[Theory]`
`61`	`61`	`[InlineData(null)]`
`62`	`62`	`[InlineData("")]`
`63`		`- public void CanReadWithoutSerilogSection(string sectionName)`
	`63`	`+ public void CanReadWithoutSerilogSection(string? sectionName)`
`64`	`64`	`{`
`65`	`65`	`LogEvent? evt = null;`
`66`	`66`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public void StringValuesConvertToDefaultInstancesIfTargetIsAbstractClass()`
`54`	`54`	`// a full-qualified type name should not be considered a static member accessor`
`55`	`55`	`[InlineData("My.NameSpace.Class, MyAssembly, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089",`
`56`	`56`	`null, null)]`
`57`		`- public void TryParseStaticMemberAccessorReturnsExpectedResults(string input, string? expectedAccessorType, string expectedPropertyName)`
	`57`	`+ public void TryParseStaticMemberAccessorReturnsExpectedResults(string? input, string? expectedAccessorType, string? expectedPropertyName)`
`58`	`58`	`{`
`59`	`59`	`var actual = StringArgumentValue.TryParseStaticMemberAccessor(input,`
`60`	`60`	`out var actualAccessorType,`