fix: work around msvc compiler bug with range-based-for in constexpr

For some unknown reason MSVC fails to evaluate at
constant-evalutation-time (constexpr) pic_array::appender::operator()
when it uses a range-based-for expression. Manually expanding it, in the
exact same way that the C++ spec says "the implementation" (compiler)
should do it, allows it to proceed.

Author: muggenhor

include/frozen/bits/pic_array.h

@@ -30,6 +30,7 @@
 #include "frozen/string.h"
 
 #include <cstdint>
+#include <iterator>
 #include <memory>
 #include <type_traits>
 #include <utility>
@@ -475,8 +476,11 @@ struct pic_array {
       constexpr_assert(str_value.data_size == item.size(), "size field causes truncation");
 
       // constexpr std::copy before C++20
-      for (const auto& val : item) {
-        array_data[store_pos++] = val;
+      // manual expansion of range-based-for because MSVC fails on that but not this
+      using std::begin;
+      using std::end;
+      for (auto i = begin(item), last = end(item); i != last; ++i) {
+        array_data[store_pos++] = *i;
       }
       if (is_nul_terminated)
         str_value.data_size -= 1;