make conversion of Length to Int safer (JuliaArrays#1175)

Now `Int(Length{StaticArraysCore.Dynamic()}())` throws a `MethodError`
instead of returning a non-`Int` value.

Some pieces of code that depended on the previous behavior are now
adjusted.

Bumped patch version to 1.6.2.

Author: nsajko

Project.toml

@@ -1,6 +1,6 @@
 name = "StaticArrays"
 uuid = "90137ffa-7385-5640-81b9-e52037218182"
-version = "1.6.1"
+version = "1.6.2"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/convert.jl

@@ -90,11 +90,16 @@ function construct_type(::Type{SA}, x) where {SA<:SizeEltypeAdaptable}
     error("Constructor for $SA is missing. Please file a bug.")
 end
 
+adapt_size_impl1(::Type{SA}, ::Any, y::Int) where {SA<:StaticArray} = y
+adapt_size_impl1(::Type{SA}, x, ::Any) where {SA<:StaticArray} = _no_precise_size(SA, x)
+
+adapt_size_impl0(::Type{SA}, x, ::Length{y}) where {SA<:StaticArray, y} = adapt_size_impl1(SA, x, y)
+
 function adapt_size(::Type{SA}, x) where {SA<:StaticArray}
     if has_size(SA) && length_match_size(SA, x)
         SZ = Tuple{size(SA)...}
     else
-        len = x isa Tuple ? length(x) : Int(Length(x))
+        len = x isa Tuple ? length(x) : adapt_size_impl0(SA, x, Length(x))
         len isa Int || _no_precise_size(SA, x)
         if SA <: StaticVector
             SZ = Tuple{len}

src/traits.jl

@@ -60,7 +60,7 @@ Base.LinearIndices(::Size{S}) where {S} = LinearIndices(S)
 @pure size_tuple(::Size{S}) where {S} = Tuple{S...}
 
 # Some @pure convenience functions for `Length`
-@pure (::Type{Int})(::Length{L}) where {L} = L
+@pure (::Type{Int})(::Length{L}) where {L} = Int(L)
 
 @pure Base.:(==)(::Length{L}, l::Int) where {L} = L == l
 @pure Base.:(==)(l::Int, ::Length{L}) where {L} = l == L