Fix compilation without default features (#1548)

This also fixes the `utils` feature without `model`.
`cargo check --no-default-features --features utils`

Additionally, it introduces a new `no default features` CI job
to prevent miscompilations when default features are disabled
in the future.

Closes #763

Author: nickelc

.github/workflows/ci.yml

@@ -19,6 +19,7 @@ jobs:
           - nightly
           - macOS
           - Windows
+          - no default features
           - no cache
           - no gateway
           - unstable Discord API features
@@ -34,6 +35,8 @@ jobs:
             os: macOS-latest
           - name: Windows
             os: windows-latest
+          - name: no default features
+            features: " "
           - name: no cache
             features: builder client framework gateway model http standard_framework utils rustls_backend
           - name: no gateway

src/model/channel/channel_id.rs

@@ -5,6 +5,7 @@ use std::sync::Arc;
 
 #[cfg(feature = "model")]
 use bytes::buf::Buf;
+#[cfg(feature = "model")]
 use futures::stream::Stream;
 #[cfg(feature = "model")]
 use reqwest::Url;
@@ -17,13 +18,14 @@ use tokio::{fs::File, io::AsyncReadExt};
 use crate::builder::{
     CreateInvite,
     CreateMessage,
+    CreateStageInstance,
     CreateThread,
     EditChannel,
     EditMessage,
+    EditStageInstance,
     EditThread,
     GetMessages,
 };
-use crate::builder::{CreateStageInstance, EditStageInstance};
 #[cfg(all(feature = "cache", feature = "model"))]
 use crate::cache::Cache;
 #[cfg(feature = "collector")]
@@ -1213,13 +1215,15 @@ impl ChannelId {
     }
 }
 
+#[cfg(feature = "model")]
 impl From<Channel> for ChannelId {
     /// Gets the Id of a [`Channel`].
     fn from(channel: Channel) -> ChannelId {
         channel.id()
     }
 }
 
+#[cfg(feature = "model")]
 impl<'a> From<&'a Channel> for ChannelId {
     /// Gets the Id of a [`Channel`].
     fn from(channel: &Channel) -> ChannelId {

src/model/channel/guild_channel.rs

@@ -13,13 +13,14 @@ use crate::builder::EditChannel;
 use crate::builder::{
     CreateInvite,
     CreateMessage,
+    CreateStageInstance,
     CreateThread,
     EditMessage,
+    EditStageInstance,
     EditThread,
     EditVoiceState,
     GetMessages,
 };
-use crate::builder::{CreateStageInstance, EditStageInstance};
 #[cfg(feature = "cache")]
 use crate::cache::Cache;
 #[cfg(feature = "collector")]

src/model/channel/message.rs

@@ -1,5 +1,6 @@
 //! Models relating to Discord channels.
 
+#[cfg(feature = "model")]
 use std::fmt::Display;
 #[cfg(all(feature = "cache", feature = "model"))]
 use std::fmt::Write;

src/model/channel/reaction.rs

@@ -1,7 +1,8 @@
+#[cfg(feature = "model")]
+use std::cmp::Ordering;
 use std::convert::TryFrom;
 use std::str::FromStr;
 use std::{
-    cmp::Ordering,
     error::Error as StdError,
     fmt::{self, Display, Formatter, Result as FmtResult, Write as FmtWrite},
 };

src/model/event.rs

@@ -1910,6 +1910,7 @@ pub enum Event {
     Unknown(UnknownEvent),
 }
 
+#[cfg(feature = "model")]
 fn gid_from_channel(c: &Channel) -> RelatedId<GuildId> {
     use RelatedId::*;
     match c {
@@ -2272,6 +2273,7 @@ macro_rules! with_related_ids_for_event_types {
     };
 }
 
+#[cfg(feature = "model")]
 macro_rules! define_event_related_id_methods {
     ($(
         $(#[$attr:meta])?
@@ -2404,6 +2406,7 @@ impl Event {
         }
     }
 
+    #[cfg(feature = "model")]
     with_related_ids_for_event_types!(define_event_related_id_methods);
 }
 

src/model/guild/emoji.rs

@@ -5,6 +5,7 @@ use serde_json::json;
 
 #[cfg(all(feature = "cache", feature = "model"))]
 use crate::cache::Cache;
+#[cfg(all(feature = "cache", feature = "model"))]
 use crate::http::Http;
 #[cfg(all(feature = "cache", feature = "model"))]
 use crate::internal::prelude::*;

src/model/guild/guild_id.rs

@@ -1,3 +1,4 @@
+#[cfg(feature = "model")]
 use futures::stream::Stream;
 #[cfg(feature = "model")]
 use serde_json::json;

src/model/guild/member.rs

@@ -1,9 +1,9 @@
 #[cfg(feature = "model")]
 use std::borrow::Cow;
+#[cfg(all(feature = "cache", feature = "model"))]
 use std::cmp::Reverse;
 use std::fmt::{Display, Formatter, Result as FmtResult};
 
-#[cfg(feature = "model")]
 use bitflags::__impl_bitflags;
 use chrono::{DateTime, Utc};
 use serde::{Serialize, Serializer};

src/model/guild/mod.rs

@@ -15,6 +15,7 @@ mod role;
 mod system_channel;
 
 use chrono::{DateTime, Utc};
+#[cfg(feature = "model")]
 use futures::stream::StreamExt;
 use serde::de::Error as DeError;
 use serde::{Serialize, Serializer};