Merge pull request #11 from slyness/connection_metrics

improve metrics for postgresql connections

Author: eheydrick

CHANGELOG.md

@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/)
 
 ## [Unreleased]
+- Correctly evaluate and collect metrics for active connections and active connections waiting on backend locks
+- Add new metric `total`
 
 ## [0.1.0] - 2016-03-09
 ### Added

bin/metric-postgres-connections.rb

@@ -77,18 +77,21 @@ def run
 
     metrics = {
       active: 0,
-      waiting: 0
+      waiting: 0,
+      total: 0
     }
     con.exec(request.join(' ')) do |result|
       result.each do |row|
-        if row['waiting']
+        if row['waiting'] == 't'
           metrics[:waiting] = row['count']
-        else
+        elsif row['waiting'] == 'f'
           metrics[:active] = row['count']
         end
       end
     end
 
+    metrics[:total] = (metrics[:waiting].to_i + metrics[:active].to_i)
+
     metrics.each do |metric, value|
       output "#{config[:scheme]}.connections.#{config[:db]}.#{metric}", value, timestamp
     end