Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (8bcb200) to head (166c15c).
Report is 4 commits behind head on dev.

@@            Coverage Diff             @@
##              dev    #1823      +/-   ##
==========================================
+ Coverage   80.40%   83.00%   +2.59%     
==========================================
  Files         278      284       +6     
  Lines       44998    48877    +3879     
  Branches    10245    10560     +315     
==========================================
+ Hits        36180    40569    +4389     
- Misses       7033     7526     +493     
+ Partials     1785      782    -1003     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seladb I've prepared only 1 constructor which initiates the layer with default fields values
Can you please mention what are the other constructors I need to implement? also please mention if I need to follow on other protocols layers?

@yahyayozo we usually have at least 2 c'tors, sometimes more:

1. As part of the packet parsing flow. For example:

   PcapPlusPlus/Packet++/header/MplsLayer.h

   Line 37 in a49a79e

   MplsLayer(uint8_t* data, size_t dataLen, Layer* prevLayer, Packet* packet)

   which is used here (and in some other places also):

   PcapPlusPlus/Packet++/src/VlanLayer.cpp

   Line 101 in a49a79e

   m_NextLayer = new MplsLayer(payload, payloadLen, this, m_Packet);

2. When the user wants to create a new layer of this type. This is the c'tor you already implemented, but usually we don't implement (only) c'tors with zero arguments. We tend to implement c'tors that allow the user to build the layer. In your case, I'd add arguments like transactionId, unitId and functionCode

Hi @seladb can you please guide me briefly on how to add tests for my ModbusLayer for parsing/crafting headers? As I want to pass to function types request/response after testing the header part.

@yahyayozo sure! You can learn about tests here: https://pcapplusplus.github.io/docs/tests

At a high level:

• You should add your tests under Tests/Packet++Test/Tests (don't forget to add your .cpp file to CMakeFiles.txt)
• The tests use a homegrown testing framework. A test case is PTF_TEST_CASE. You can write 3 of those: for parsing, crafting, and editing
• You can find the possible assertions here, the most common one is PTF_ASSERT_EQUAL(actual, expected)
• You need to add your test cases to https://github.com/seladb/PcapPlusPlus/blob/master/Tests/Packet%2B%2BTest/main.cpp and add a PTF_RUN_TEST for each test case
• When you build the tests, you should run them from the Tests/Packet++Test directory, like this: Bin/Packet++Test -t <YOUR_TEST_CASE>

Please look at similar tests that were written for other layers and follow the same patterns.

Please let me know if you have any questions.

@seladb I'll add tests for the headers crafting/parsing implementation and then you can a review before we move to adding the different PDU types