Replace more NULLs with nullptr (#1556)

Author: DeepakReddy1999

Examples/IcmpFileTransfer/IcmpFileTransfer-pitcher.cpp

@@ -36,12 +36,15 @@ void usleep(__int64 usec)
 	LARGE_INTEGER ft;
 
 	ft.QuadPart = -(10 * usec);  // Convert to 100 nanosecond interval, negative value indicates relative time
-
+	// NULL is used instead of nullptr for Windows APIs. Check
+	// https://devblogs.microsoft.com/oldnewthing/20180307-00/?p=98175
 	timer = CreateWaitableTimer(NULL, TRUE, NULL);
 	if (timer == nullptr)
 	{
 		throw std::runtime_error("Could not create waitable timer with error: " + std::to_string(GetLastError()));
 	}
+	// NULL is used instead of nullptr for Windows APIs. Check
+	// https://devblogs.microsoft.com/oldnewthing/20180307-00/?p=98175
 	SetWaitableTimer(timer, &ft, 0, NULL, NULL, 0);
 	WaitForSingleObject(timer, INFINITE);
 	CloseHandle(timer);

Pcap++/src/RawSocketDevice.cpp

@@ -430,6 +430,8 @@ namespace pcpp
 
 		int n = 1;
 		DWORD dwBytesRet;
+		// NULL is used instead of nullptr for Windows APIs. Check
+		// https://devblogs.microsoft.com/oldnewthing/20180307-00/?p=98175
 		if (WSAIoctl(fd, SIO_RCVALL, &n, sizeof(n), NULL, 0, &dwBytesRet, NULL, NULL) == SOCKET_ERROR)
 		{
 			PCPP_LOG_ERROR("Call to WSAIotcl(" << std::hex << SIO_RCVALL << ") failed with error code "

Tests/Fuzzers/FuzzTarget.cpp

@@ -10,7 +10,7 @@ static std::string tmpFile;
 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
 {
 	if (tmpName.empty())
-		tmpName = tmpnam(NULL);
+		tmpName = tmpnam(nullptr);
 
 	if (tmpFile.empty())
 		tmpFile = tmpName + FILE_EXT;
@@ -59,7 +59,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
 			pcpp::Packet parsedPacket(&rawPacket);
 			parsedPacket.toString();
 			auto layer = parsedPacket.getFirstLayer();
-			while (layer != NULL)
+			while (layer != nullptr)
 			{
 				std::cout << layer->toString() << std::endl;
 				layer->getHeaderLen();

Tests/Fuzzers/FuzzWriter.cpp

@@ -13,7 +13,7 @@ static int writes = 0;
 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
 {
 	if (tmpName.empty())
-		tmpName = tmpnam(NULL);
+		tmpName = tmpnam(nullptr);
 
 	if (tmpFile.empty())
 		tmpFile = tmpName + FILE_EXT;