Skip to content

Commit d517b3e

Browse files
José Carlos Ferreirosekipaolo
José Carlos Ferreiro
authored andcommitted
fix tags filter to retrieve specified tags not excluding specified tags (#34)
* fix tags filter to retrieve specified tags not excluding specified tags * fix tests and return value when filters is empty
1 parent d7cf6da commit d517b3e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pypingdom/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ def get_check(self, name=None, _id=None):
4343

4444
def get_checks(self, filters=None):
4545
if filters is None:
46-
filters = {}
47-
return [c for c in self.checks.values() if len(set(filters.get("tags", [])).intersection(set([x['name']
46+
return [c for c in self.checks.values()]
47+
return [c for c in self.checks.values() if not len(set(filters.get("tags", [])).intersection(set([x['name']
4848
for x in c.tags]))) == 0]
4949

5050
def create_check(self, name, obj):

pypingdom/tests/test_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,4 @@ def test_get_checks(self, m):
7070
self.assertTrue(all(isinstance(x, Check) for x in res))
7171

7272
res = client.get_checks(filters={"tags": ['apache']})
73-
self.assertEqual(len(res), 2)
73+
self.assertEqual(len(res), 1)

0 commit comments

Comments
 (0)