Simplify create_check() by removing redundant argument (#45)

Author: infothrill

README.rst

@@ -125,7 +125,7 @@ Create a check:
             "tags": [{"name": "pypingdom-test"}, {"name": "custom-tag"}],
             "encryption": False
         }
-    >>> client.create_check('My awesome check', check_definition)
+    >>> client.create_check(check_definition)
 
 
 Refers to `this page <https://www.pingdom.com/resources/api#MethodCreate+New+Check>`_ for the list of options.

pypingdom/client.py

@@ -47,13 +47,13 @@ def get_checks(self, filters=None):
         return [c for c in self.checks.values() if not len(set(filters.get("tags", [])).intersection(set([x['name']
                 for x in c.tags]))) == 0]
 
-    def create_check(self, name, obj):
+    def create_check(self, obj):
         c = Check(self.api, obj=obj)
         data = c.to_json()
         response = self.api.send(method='post', resource='checks', data=data)
         c._id = int(response["check"]["id"])
         c.from_json(self.api.send('get', "checks", response["check"]["id"])['check'])
-        self.checks[name] = c
+        self.checks[c.name] = c
         return c
 
     def delete_check(self, check):

testing/manualtest_check.py

@@ -44,7 +44,7 @@ def clean():
 
 def create_check():
     global client, check_definition
-    c = client.create_check(check_definition["name"], check_definition)
+    c = client.create_check(check_definition)
     print("created %s" % c.name)
     check = client.get_check(check_definition["name"])
     assert check is not None  # nosec