Skip to content

Commit 6223086

Browse files
José Carlos Ferreirosekipaolo
José Carlos Ferreiro
authored andcommitted
Fix get checks by tags (#29)
* generate proper checks' tags Set so filter works * Fixe code on some examples
1 parent a38e858 commit 6223086

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

README.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ Retreive maintenance windows for production websites in the last 7 days:
159159
.. code-block:: python
160160
161161
>>> import datetime
162-
>>> checks = client.get_checks(filters={"tags": ["production": "frontend"]})
162+
>>> checks = client.get_checks(filters={"tags": ["production", "frontend"]})
163163
>>> start = datetime.datetime.now() - datetime.timedelta(days=7)
164-
>>> client.get_maintenances(filters={"checks": checks, "after": start}):
164+
>>> client.get_maintenances(filters={"checks": checks, "after": start})
165165
166166
Create a 1 hour maintenance window for production websites:
167167

@@ -170,7 +170,7 @@ Create a 1 hour maintenance window for production websites:
170170
>>> start = datetime.datetime.now() + datetime.timedelta(minutes=10)
171171
>>> end = start + datetime.timedelta(hours=1)
172172
173-
>>> window = client.create_maintenance(filters={"checks": checks, "name": "pypingdom test maintenance", "start": start, "stop": stop})
173+
>>> window = client.create_maintenance({"checks": checks, "name": "pypingdom test maintenance", "start": start, "stop": end})
174174
175175
Delete future maintenance windows:
176176

pypingdom/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def get_checks(self, filters=None):
4646
filters = {}
4747
res = []
4848
for _name, check in self.checks.items():
49-
if "tags" in filters and len(set(filters["tags"]).intersection(set(check.tags))) == 0:
49+
if "tags" in filters and len(set(filters["tags"]).intersection(set([x['name'] for x in check.tags]))) == 0:
5050
continue
5151
res.append(check)
5252
return res

0 commit comments

Comments
 (0)