BugSplat Crash: SecondLifeViewer!std::_Atomic_storage<enum boost::fibers::detail::spinlock_status,4>::load(956)

[sl-service-account]

BugSplat Crash Group 102965

View Report Group
View Report Details
View Report Attachments

Application: Second Life Release
Version: 7.2.3.18887079901
Error Code: c0000005 Access violation

Callstack:

Function	File
SecondLifeViewer!std::_Atomic_storage::load	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.42.34433/include/atomic(956)
SecondLifeViewer!boost::fibers::detail::spinlock_ttas::lock	C:/a/3p-boost/3p-boost/boost/boost/fiber/detail/spinlock_ttas.hpp(57)
SecondLifeViewer!std::unique_lock::{ctor}	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.42.34433/include/mutex(144)
SecondLifeViewer!boost::fibers::mutex::lock	C:/a/3p-boost/3p-boost/boost/libs/fiber/src/mutex.cpp(29)
SecondLifeViewer!std::unique_lock::{ctor}	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/mutex(144)
SecondLifeViewer!LLPluginProcessParent::poll	C:/a/viewer/viewer/indra/llplugin/llpluginprocessparent.cpp(987)
SecondLifeViewer!LLPluginProcessParentPollThread::run	C:/a/viewer/viewer/indra/llplugin/llpluginprocessparent.cpp(70)
SecondLifeViewer!LLThread::tryRun	C:/a/viewer/viewer/indra/llcommon/llthread.cpp(209)
SecondLifeViewer!LLThread::sehHandle	C:/a/viewer/viewer/indra/llcommon/llthread.cpp(254)
SecondLifeViewer!LLThread::threadRun	C:/a/viewer/viewer/indra/llcommon/llthread.cpp(195)
SecondLifeViewer!std::invoke	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/type_traits(1686)
SecondLifeViewer!std::_Invoker_ret::_Call	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/functional(2117)
SecondLifeViewer!std::_Call_binder	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/functional(2127)
SecondLifeViewer!std::_Binder::operator()	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/functional(2181)
SecondLifeViewer!std::invoke	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/type_traits(1670)
SecondLifeViewer!std::thread::_Invoke >,0>	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/thread(61)
ucrtbase!thread_start	-
kernel32!BaseThreadInitThunk	-
ntdll!RtlUserThreadStart	-

---

This repo is using Opire - what does it mean? 👇

💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #4918 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @sl-service-account (replace 20 with the amount, and @sl-service-account with the user to tip).

📖 If you want to learn more, check out our documentation.

[akleshchev]

Might be caused by this one: 0d5138c

Might need to create a temporary storage for the content of the sInstances like it'sdone in pollTick() or sInstancesMutex is just null...

[Dan-Linden]

Passed QA.
Verified on Second Life Release 7.2.3.18980112811 on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/565

Not tested

[vldevel]

Might be caused by this one: 0d5138c

Might need to create a temporary storage for the content of the sInstances like it'sdone in pollTick() or sInstancesMutex is just null...

I never seen such a crash in my viewer, but I'm using a non-fiber-aware LLMutex (plugins do not use fibers and the llplugin API is not used from fibers), and I'm using explicit sInstancesMutex.lock() and sInstancesMutex.unlock() instead of scoped instance using a pointer on that static member variable.

If not sufficient, an alternative would be to remove sInstancesMutex from the member variables of LLPluginProcessParent and instead declare a LLMutex gInstancesMutex; at the global scope in llpluginprocessparent.cpp: this way, you ensure that gInstancesMutex will outlive the destruction of the LLPluginProcessParent class on plugin/viewer shutdown.