Merge pull request #33 from Unity-Technologies/LayeredLit

Layeredlit

Author: JulienIgnace-Unity

Assets/ScriptableRenderLoop/HDRenderLoop/Material/LayeredLit/Editor/LayeredLitUI.cs

@@ -41,7 +41,7 @@ private class StylesLayer
             public readonly GUIContent layerMapMaskText = new GUIContent("Layer Mask", "Layer mask (multiplied by vertex color if enabled)");
             public readonly GUIContent layerMapVertexColorText = new GUIContent("Use Vertex Color", "Layer mask (multiplied by layer mask if enabled)");
             public readonly GUIContent layerCountText = new GUIContent("Layer Count", "Number of layers.");
-            public readonly GUIContent layerTexWorldScaleText = new GUIContent("Tex world scale", "Scale to apply to world position for Planar/Trilinear");
+            public readonly GUIContent layerTexWorldScaleText = new GUIContent("Tiling", "Tiling factor applied to Planar/Trilinear mapping");
             public readonly GUIContent UVBaseText = new GUIContent("Base UV Mapping", "Base UV Mapping mode of the layer.");
             public readonly GUIContent UVDetailText = new GUIContent("Detail UV Mapping", "Detail UV Mapping mode of the layer.");
         }

Assets/ScriptableRenderLoop/HDRenderLoop/Material/LayeredLit/LayeredLit.shader

@@ -134,10 +134,10 @@ Shader "HDRenderLoop/LayeredLit"
 		// All the following properties that concern the UV mapping are the same as in the Lit shader.
 		// This means that they will get overridden when synchronizing the various layers.
 		// To avoid this, make sure that all properties here are in the exclusion list in LayeredLitUI.SynchronizeLayerProperties
-        _TexWorldScale0("Scale to apply on world coordinate", Float) = 1.0
-        _TexWorldScale1("Scale to apply on world coordinate", Float) = 1.0
-        _TexWorldScale2("Scale to apply on world coordinate", Float) = 1.0
-        _TexWorldScale3("Scale to apply on world coordinate", Float) = 1.0
+        _TexWorldScale0("Tiling", Float) = 1.0
+        _TexWorldScale1("Tiling", Float) = 1.0
+        _TexWorldScale2("Tiling", Float) = 1.0
+        _TexWorldScale3("Tiling", Float) = 1.0
 
         [Enum(UV0, 0, UV1, 1, UV3, 2, Planar, 3, Triplanar, 4)] _UVBase0("UV Set for base0", Float) = 0
         [Enum(UV0, 0, UV1, 1, UV3, 2, Planar, 3, Triplanar, 4)] _UVBase1("UV Set for base1", Float) = 0
@@ -162,7 +162,7 @@ Shader "HDRenderLoop/LayeredLit"
         // Unused but to be able to share litUI.Sahder and layeredUI.Shader
         [HideInInspector] _UVBase("UV Set for base", Float) = 0
         [HideInInspector] _UVDetail("UV Set for base", Float) = 0
-        [HideInInspector] _TexWorldScale("Scale to apply on world coordinate", Float) = 1.0
+        [HideInInspector] _TexWorldScale("Tiling", Float) = 1.0
         [HideInInspector] _UVMappingMask("_UVMappingMask", Color) = (1, 0, 0, 0)
         [HideInInspector] _UVDetailsMappingMask("_UVDetailsMappingMask", Color) = (1, 0, 0, 0)
     }

Assets/ScriptableRenderLoop/HDRenderLoop/Material/Lit/Editor/BaseLitUI.cs

@@ -25,7 +25,7 @@ protected static class Styles
 
             public static GUIContent smoothnessMapChannelText = new GUIContent("Smoothness Source", "Smoothness texture and channel");
             public static GUIContent UVBaseMappingText = new GUIContent("UV set for Base", "");
-            public static GUIContent texWorldScaleText = new GUIContent("Scale to apply on world coordinate in case of Planar/Triplanar", "");
+            public static GUIContent texWorldScaleText = new GUIContent("Tiling", "Tiling factor applied to Planar/Trilinear mapping");
             public static GUIContent UVBaseDetailMappingText = new GUIContent("UV set for Base and Detail", "");
             public static GUIContent normalMapSpaceText = new GUIContent("Normal/Tangent Map space", "");
             public static GUIContent heightMapModeText = new GUIContent("Height Map Mode", "");

Assets/ScriptableRenderLoop/HDRenderLoop/Material/Lit/LitSurfaceData.hlsl

@@ -9,28 +9,33 @@ void ADD_IDX(ComputeLayerTexCoord)(FragInput input, bool isTriplanar, inout Laye
     ADD_IDX(layerTexCoord.base).uv =    ADD_IDX(_UVMappingMask).x * input.texCoord0 +
                                         ADD_IDX(_UVMappingMask).y * input.texCoord1 + 
                                         ADD_IDX(_UVMappingMask).z * input.texCoord3 +
-                                        ADD_IDX(_UVMappingMask).w * position.xz;
+                                        ADD_IDX(_UVMappingMask).w * -position.xz;
 
     float2 uvDetails =  ADD_IDX(_UVDetailsMappingMask).x * input.texCoord0 +
                         ADD_IDX(_UVDetailsMappingMask).y * input.texCoord1 +
                         ADD_IDX(_UVDetailsMappingMask).z * input.texCoord3 +
                         // Note that if base is planar, detail map is planar
-                        ADD_IDX(_UVMappingMask).w * position.xz;
+                        ADD_IDX(_UVMappingMask).w * -position.xz;
 
     ADD_IDX(layerTexCoord.details).uv = TRANSFORM_TEX(uvDetails, ADD_IDX(_DetailMap));
 
     // triplanar
     ADD_IDX(layerTexCoord.base).isTriplanar = isTriplanar;
 
-    ADD_IDX(layerTexCoord.base).uvYZ = position.zy;
-    ADD_IDX(layerTexCoord.base).uvZX = position.xz;
-    ADD_IDX(layerTexCoord.base).uvXY = float2(-position.x, position.y);
+    float3 direction = sign(input.tangentToWorld[2].xyz);
+
+    // In triplanar, if we are facing away from the world axis, a different axis will be flipped for each direction.
+    // This is particularly problematic for tangent space normal maps which need to be in the right direction.
+    // So we multiplying the offending coordinate by the sign of the normal.
+    ADD_IDX(layerTexCoord.base).uvYZ = float2(direction.x * position.z, position.y);
+    ADD_IDX(layerTexCoord.base).uvZX = -float2(position.x, direction.y * position.z);
+    ADD_IDX(layerTexCoord.base).uvXY = float2(-position.x, direction.z * position.y);
 
     ADD_IDX(layerTexCoord.details).isTriplanar = isTriplanar;
 
-    ADD_IDX(layerTexCoord.details).uvYZ = TRANSFORM_TEX(position.zy, ADD_IDX(_DetailMap));
-    ADD_IDX(layerTexCoord.details).uvZX = TRANSFORM_TEX(position.xz, ADD_IDX(_DetailMap));
-    ADD_IDX(layerTexCoord.details).uvXY = TRANSFORM_TEX(float2(-position.x, position.y), ADD_IDX(_DetailMap));
+    ADD_IDX(layerTexCoord.details).uvYZ = TRANSFORM_TEX(ADD_IDX(layerTexCoord.base).uvYZ, ADD_IDX(_DetailMap));
+    ADD_IDX(layerTexCoord.details).uvZX = TRANSFORM_TEX(ADD_IDX(layerTexCoord.base).uvZX, ADD_IDX(_DetailMap));
+    ADD_IDX(layerTexCoord.details).uvXY = TRANSFORM_TEX(ADD_IDX(layerTexCoord.base).uvXY, ADD_IDX(_DetailMap));
 }
 
 void ADD_IDX(ApplyDisplacement)(inout FragInput input, inout LayerTexCoord layerTexCoord)
@@ -156,7 +161,7 @@ float ADD_IDX(GetSurfaceData)(FragInput input, LayerTexCoord layerTexCoord, out
 #else
     surfaceData.perceptualSmoothness = 1.0;
 #endif
-	surfaceData.perceptualSmoothness *= ADD_IDX(_Smoothness);
+    surfaceData.perceptualSmoothness *= ADD_IDX(_Smoothness);
 #ifdef _DETAIL_MAP
     surfaceData.perceptualSmoothness *= LerpWhiteTo(2.0 * saturate(detailSmoothness * ADD_IDX(_DetailSmoothnessScale)), detailMask);
 #endif