Skip to content

Commit 5ac1697

Browse files
Fixed multipliers on LayeredLit for Smoothness, Metallic and Anisotropy (were always 0 before).
1 parent 5044c62 commit 5ac1697

File tree

10 files changed

+20
-15
lines changed

10 files changed

+20
-15
lines changed

Assets/ScriptableRenderLoop/HDRenderLoop/Material/Lit/LitSurfaceData.hlsl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ float ADD_IDX(GetSurfaceData)(FragInput input, LayerTexCoord layerTexCoord, out
156156
#else
157157
surfaceData.perceptualSmoothness = 1.0;
158158
#endif
159-
surfaceData.perceptualSmoothness *= _Smoothness;
159+
surfaceData.perceptualSmoothness = ADD_IDX(_Smoothness);
160160
#ifdef _DETAIL_MAP
161161
surfaceData.perceptualSmoothness *= LerpWhiteTo(2.0 * saturate(detailSmoothness * ADD_IDX(_DetailSmoothnessScale)), detailMask);
162162
#endif
@@ -169,7 +169,7 @@ float ADD_IDX(GetSurfaceData)(FragInput input, LayerTexCoord layerTexCoord, out
169169
surfaceData.metallic = 1.0;
170170
surfaceData.ambientOcclusion = 1.0;
171171
#endif
172-
surfaceData.metallic *= _Metallic;
172+
surfaceData.metallic *= ADD_IDX(_Metallic);
173173

174174
// This part of the code is not used in case of layered shader but we keep the same macro system for simplicity
175175
#if !defined(LAYERED_LIT_SHADER)
@@ -194,7 +194,7 @@ float ADD_IDX(GetSurfaceData)(FragInput input, LayerTexCoord layerTexCoord, out
194194
#else
195195
surfaceData.anisotropy = 1.0;
196196
#endif
197-
surfaceData.anisotropy *= _Anisotropy;
197+
surfaceData.anisotropy *= ADD_IDX(_Anisotropy);
198198

199199
surfaceData.specular = 0.04;
200200

Binary file not shown.

Assets/TestScenes/HDTest/LayeredLitTest/Material/Layered_BlendColor.mat

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ Material:
1212
_DISTORTIONONLY_OFF _EMISSION _EMISSIVE_COLOR _LAYEREDLIT_4_LAYER _LAYEREDLIT_4_LAYERS
1313
_LAYERMASKMAP _LAYER_MAPPING_PLANAR0 _LAYER_MAPPING_PLANAR_0 _LAYER_MAPPING_PLANAR_1
1414
_LAYER_MAPPING_PLANAR_2 _LAYER_MAPPING_PLANAR_3 _LAYER_MASK_VERTEX_COLOR _NORMALMAP_TANGENT_SPACE
15-
_REQUIRE_UV3
1615
m_LightmapFlags: 1
1716
m_CustomRenderQueue: -1
1817
stringTagMap: {}
18+
disabledShaderPasses: []
1919
m_SavedProperties:
2020
serializedVersion: 3
2121
m_TexEnvs:
@@ -312,9 +312,9 @@ Material:
312312
- _Parallax: 0.02
313313
- _Smoothness: 0.5
314314
- _Smoothness0: 0.5
315-
- _Smoothness1: 0.5
315+
- _Smoothness1: 0.2
316316
- _Smoothness2: 0.5
317-
- _Smoothness3: 0.5
317+
- _Smoothness3: 0.4
318318
- _SmoothnessTextureChannel: 0
319319
- _SpecularHighlights: 1
320320
- _SrcBlend: 1

Assets/TestScenes/HDTest/LayeredLitTest/Material/Layered_BlendColor.mat.meta

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Assets/TestScenes/HDTest/LayeredLitTest/Material/Layered_Layer3_Triplanar.mat

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@ Material:
1010
m_Shader: {fileID: 4800000, guid: 81d02e8644315b742b154842a3a2f98c, type: 3}
1111
m_ShaderKeywords: _ALPHACUTOFFENABLE_OFF _DETAIL_MAP _DETAIL_MAP_WITH_NORMAL _DISTORTIONDEPTHTEST_OFF
1212
_DISTORTIONONLY_OFF _EMISSION _EMISSIVE_COLOR _LAYEREDLIT_4_LAYERS _LAYER_MAPPING_TRIPLANAR_3
13-
_LAYER_MASK_VERTEX_COLOR _NORMALMAP_TANGENT_SPACE _REQUIRE_UV3
13+
_LAYER_MASK_VERTEX_COLOR _NORMALMAP_TANGENT_SPACE
1414
m_LightmapFlags: 1
1515
m_CustomRenderQueue: -1
1616
stringTagMap: {}
17+
disabledShaderPasses: []
1718
m_SavedProperties:
1819
serializedVersion: 3
1920
m_TexEnvs:

Assets/TestScenes/HDTest/LayeredLitTest/Material/Layered_Layer3_Triplanar.mat.meta

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Assets/TestScenes/HDTest/LayeredLitTest/Material/Lit_Blue.mat

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@ Material:
99
m_Name: Lit_Blue
1010
m_Shader: {fileID: 4800000, guid: 6e4ae4064600d784cac1e41a9e6f2e59, type: 3}
1111
m_ShaderKeywords: _ALPHACUTOFFENABLE_OFF _DETAIL_MAP_WITH_NORMAL _DISTORTIONDEPTHTEST_OFF
12-
_DISTORTIONONLY_OFF _EMISSION _NORMALMAP_TANGENT_SPACE _REQUIRE_UV3
12+
_DISTORTIONONLY_OFF _EMISSION _NORMALMAP_TANGENT_SPACE
1313
m_LightmapFlags: 1
1414
m_CustomRenderQueue: -1
1515
stringTagMap: {}
16+
disabledShaderPasses: []
1617
m_SavedProperties:
1718
serializedVersion: 3
1819
m_TexEnvs:
@@ -125,7 +126,7 @@ Material:
125126
- _NormalMapSpace: 0
126127
- _OcclusionStrength: 1
127128
- _Parallax: 0.02
128-
- _Smoothness: 0.5
129+
- _Smoothness: 0.4
129130
- _SmoothnessTextureChannel: 0
130131
- _SpecularHighlights: 1
131132
- _SrcBlend: 1

Assets/TestScenes/HDTest/LayeredLitTest/Material/Lit_Green.mat

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@ Material:
99
m_Name: Lit_Green
1010
m_Shader: {fileID: 4800000, guid: 6e4ae4064600d784cac1e41a9e6f2e59, type: 3}
1111
m_ShaderKeywords: _ALPHACUTOFFENABLE_OFF _DETAIL_MAP_WITH_NORMAL _DISTORTIONDEPTHTEST_OFF
12-
_DISTORTIONONLY_OFF _EMISSION _NORMALMAP_TANGENT_SPACE _REQUIRE_UV3
12+
_DISTORTIONONLY_OFF _EMISSION _NORMALMAP_TANGENT_SPACE
1313
m_LightmapFlags: 1
1414
m_CustomRenderQueue: -1
1515
stringTagMap: {}
16+
disabledShaderPasses: []
1617
m_SavedProperties:
1718
serializedVersion: 3
1819
m_TexEnvs:

Assets/TestScenes/HDTest/LayeredLitTest/Material/Lit_Red.mat

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@ Material:
99
m_Name: Lit_Red
1010
m_Shader: {fileID: 4800000, guid: 6e4ae4064600d784cac1e41a9e6f2e59, type: 3}
1111
m_ShaderKeywords: _ALPHACUTOFFENABLE_OFF _DETAIL_MAP_WITH_NORMAL _DISTORTIONDEPTHTEST_OFF
12-
_DISTORTIONONLY_OFF _EMISSION _NORMALMAP_TANGENT_SPACE _REQUIRE_UV3
12+
_DISTORTIONONLY_OFF _EMISSION _NORMALMAP_TANGENT_SPACE
1313
m_LightmapFlags: 1
1414
m_CustomRenderQueue: -1
1515
stringTagMap: {}
16+
disabledShaderPasses: []
1617
m_SavedProperties:
1718
serializedVersion: 3
1819
m_TexEnvs:
@@ -125,7 +126,7 @@ Material:
125126
- _NormalMapSpace: 0
126127
- _OcclusionStrength: 1
127128
- _Parallax: 0.02
128-
- _Smoothness: 0.5
129+
- _Smoothness: 0.2
129130
- _SmoothnessTextureChannel: 0
130131
- _SpecularHighlights: 1
131132
- _SrcBlend: 1

Assets/TestScenes/HDTest/LayeredLitTest/Material/Lit_White.mat

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@ Material:
99
m_Name: Lit_White
1010
m_Shader: {fileID: 4800000, guid: 6e4ae4064600d784cac1e41a9e6f2e59, type: 3}
1111
m_ShaderKeywords: _ALPHACUTOFFENABLE_OFF _DETAIL_MAP_WITH_NORMAL _DISTORTIONDEPTHTEST_OFF
12-
_DISTORTIONONLY_OFF _EMISSION _NORMALMAP_TANGENT_SPACE _REQUIRE_UV3
12+
_DISTORTIONONLY_OFF _EMISSION _NORMALMAP_TANGENT_SPACE
1313
m_LightmapFlags: 1
1414
m_CustomRenderQueue: -1
1515
stringTagMap: {}
16+
disabledShaderPasses: []
1617
m_SavedProperties:
1718
serializedVersion: 3
1819
m_TexEnvs:

0 commit comments

Comments
 (0)