HDRenderLoop: Enable forward rendering correctly

Author: sebastienlagarde

Assets/ScriptableRenderLoop/HDRenderLoop/HDRenderLoop.cs

@@ -360,18 +360,17 @@ void RenderGBuffer(CullResults cull, Camera camera, RenderLoop renderLoop)
         }
 
         // This pass is use in case of forward opaque and deferred rendering. We need to render forward objects before tile lighting pass
-        void RenderForwardOpaqueDepth(CullResults cull, Camera camera, RenderLoop renderLoop)
+        void RenderForwardOnlyDepthPrepass(CullResults cull, Camera camera, RenderLoop renderLoop)
         {
-            // If we have render a depth prepass, no need for this pass
-            if (debugParameters.useDepthPrepass)
+            // If we are forward only we don't need to render ForwardOpaqueDepth object
+            // But in case we request a prepass we render it
+            if (debugParameters.useForwardRenderingOnly && !debugParameters.useDepthPrepass)
                 return;
 
             using (new Utilities.ProfilingSample("Forward opaque depth", renderLoop))
             {
-                // TODO: Use the render queue index to only send the forward opaque!
-                // or use the new MAterial.SetPassEnable ?
                 Utilities.SetRenderTarget(renderLoop, m_CameraDepthBufferRT);
-                RenderOpaqueRenderList(cull, camera, renderLoop, "DepthOnly");
+                RenderOpaqueRenderList(cull, camera, renderLoop, "ForwardOnlyDepthOnly");
             }
         }
 
@@ -462,6 +461,22 @@ void RenderForward(CullResults cullResults, Camera camera, RenderLoop renderLoop
             }
         }
 
+        // Render material that are forward opaque only (like eye)
+        // TODO: Think about hair that could be render both as opaque and transparent...
+        void RenderForwardOnly(CullResults cullResults, Camera camera, RenderLoop renderLoop)
+        {
+            using (new Utilities.ProfilingSample("Forward Only Pass", renderLoop))
+            {
+                // Bind material data
+                m_LitRenderLoop.Bind();
+
+                Utilities.SetRenderTarget(renderLoop, m_CameraColorBufferRT, m_CameraDepthBufferRT);
+
+                m_lightLoop.RenderForward(camera, renderLoop, true);
+                RenderOpaqueRenderList(cullResults, camera, renderLoop, "ForwardOnly");
+            }
+        }
+
         void RenderForwardUnlit(CullResults cullResults, Camera camera, RenderLoop renderLoop)
         {
             using (new Utilities.ProfilingSample("Forward Unlit Pass", renderLoop))
@@ -651,16 +666,11 @@ public override void Render(Camera[] cameras, RenderLoop renderLoop)
 
                 RenderDepthPrepass(cullResults, camera, renderLoop);
 
-                RenderGBuffer(cullResults, camera, renderLoop);
-
-                // Forward opaque with deferred tile require that we fill the depth buffer
+                // Forward opaque with deferred/cluster tile require that we fill the depth buffer
                 // correctly to build the light list.
                 // TODO: avoid double lighting by tagging stencil or gbuffer that we must not lit.
-                // TODO: ask Morten why this pass is not before GBuffer ? Will make more sense and avoid
-                // to do gbuffer pass on unseen mesh.
-                // TODO: how do we select only the object that must be render forward ?
-                // this is all object with gbuffer pass disabled ?
-                //RenderForwardOpaqueDepth(cullResults, camera, renderLoop);
+                RenderForwardOnlyDepthPrepass(cullResults, camera, renderLoop);
+                RenderGBuffer(cullResults, camera, renderLoop);
 
                 if (debugParameters.debugViewMaterial != 0)
                 {
@@ -685,8 +695,8 @@ public override void Render(Camera[] cameras, RenderLoop renderLoop)
                     }
                     RenderDeferredLighting(camera, renderLoop);
 
-                    // TODO: enable this for tile forward opaque
-               //     RenderForward(cullResults, camera, renderLoop, true);
+                    RenderForward(cullResults, camera, renderLoop, true);
+                    RenderForwardOnly(cullResults, camera, renderLoop);
 
                     RenderSky(camera, renderLoop);