Implement TestCase->expectProcessExit($exitCode)
#6275
Draft
+111
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jul 15, 2025
| public function testOne(?int $expectedExit, int $actualExitCode): void | ||
| { | ||
| if ($expectedExit !== null) { | ||
| $this->expectProcessExit($expectedExit); |
There was a problem hiding this comment.
we should add a PHPUnit error/warning when expectProcessExit is called in a test, which does not use process-isolation
staabm
commented
Jul 15, 2025
Comment on lines
+77
to
+85
| if ($childResult->expectedProcessExit !== null && $childResult->testCalledExit === true) { | ||
| assert($test instanceof TestCase); | ||
|
|
||
| $test->assertSame($childResult->expectedProcessExit, $exitCode, 'Process exit-code expectation failed'); | ||
| } elseif ($childResult->expectedProcessExit !== null && $childResult->testCalledExit === false) { | ||
| $test->fail('Process expected exit() to be called but test did not call it'); | ||
| } elseif ($childResult->expectedProcessExit === null && $childResult->testCalledExit === false) { | ||
| $test->fail('Process called exit() but the test did not expect it'); | ||
| } |
There was a problem hiding this comment.
we need something here which allows us to combine parent-process level assertions with the child process results into a overall result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC for #6234