Separate TestTrigger from SelfTrigger

Author: sebastianbergmann

src/Event/Value/Test/Issue/TestTrigger.php

@@ -24,14 +24,6 @@ public function isTest(): true
         return true;
     }
 
-    /**
-     * Your own code triggers an issue in your own code.
-     */
-    public function isSelf(): true
-    {
-        return true;
-    }
-
     public function asString(): string
     {
         return 'issue triggered by test code';

src/Runner/IssueFilter.php

@@ -44,7 +44,8 @@ public function shouldBeProcessed(DeprecationTriggered|ErrorTriggered|NoticeTrig
                 return false;
             }
 
-            if ($this->source->ignoreSelfDeprecations() && $event->trigger()->isSelf()) {
+            if ($this->source->ignoreSelfDeprecations() &&
+                ($event->trigger()->isTest() || $event->trigger()->isSelf())) {
                 return false;
             }
 

src/TextUI/Output/Default/ProgressPrinter/ProgressPrinter.php

@@ -141,7 +141,8 @@ public function testTriggeredDeprecation(DeprecationTriggered $event): void
             return;
         }
 
-        if ($this->source->ignoreSelfDeprecations() && $event->trigger()->isSelf()) {
+        if ($this->source->ignoreSelfDeprecations() &&
+            ($event->trigger()->isTest() || $event->trigger()->isSelf())) {
             return;
         }
 
@@ -171,7 +172,8 @@ public function testTriggeredPhpDeprecation(PhpDeprecationTriggered $event): voi
             return;
         }
 
-        if ($this->source->ignoreSelfDeprecations() && $event->trigger()->isSelf()) {
+        if ($this->source->ignoreSelfDeprecations() &&
+            ($event->trigger()->isTest() || $event->trigger()->isSelf())) {
             return;
         }
 

tests/unit/Event/Value/Test/IssueTriggerTest.php

@@ -26,7 +26,7 @@ public function testCanBeTest(): void
         $trigger = IssueTrigger::test();
 
         $this->assertTrue($trigger->isTest());
-        $this->assertTrue($trigger->isSelf());
+        $this->assertFalse($trigger->isSelf());
         $this->assertFalse($trigger->isDirect());
         $this->assertFalse($trigger->isIndirect());
         $this->assertFalse($trigger->isUnknown());