Fix PHPStan errors on properties

staabm · sebastianbergmann · commit 3646e476e698 · 2024-11-17T09:24:41.000+01:00
diff --git a/src/Framework/Constraint/Type/IsType.php b/src/Framework/Constraint/Type/IsType.php
@@ -128,7 +128,6 @@ final class IsType extends Constraint
      */
     public function __construct(string $type)
     {
-        /** @phpstan-ignore isset.offset */
         if (!isset(self::KNOWN_TYPES[$type])) {
             throw new UnknownTypeException($type);
         }
diff --git a/src/Logging/TeamCity/TeamCityLogger.php b/src/Logging/TeamCity/TeamCityLogger.php
@@ -49,7 +49,7 @@ final class TeamCityLogger
     private readonly Printer $printer;
     private bool $isSummaryTestCountPrinted = false;
     private ?HRTime $time                   = null;
-    private ?int $flowId;
+    private ?int $flowId                    = null;
 
     /**
      * @throws EventFacadeIsSealedException
diff --git a/src/TextUI/Help.php b/src/TextUI/Help.php
@@ -32,7 +32,7 @@ final class Help
     private const LEFT_MARGIN              = '  ';
     private int $lengthOfLongestOptionName = 0;
     private readonly int $columnsAvailableForDescription;
-    private ?bool $hasColor;
+    private bool $hasColor;
 
     public function __construct(?int $width = null, ?bool $withColor = null)
     {

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,6 @@ final class IsType extends Constraint`
`128`	`128`	`*/`
`129`	`129`	`public function __construct(string $type)`
`130`	`130`	`{`
`131`		`- /** @phpstan-ignore isset.offset */`
`132`	`131`	`if (!isset(self::KNOWN_TYPES[$type])) {`
`133`	`132`	`throw new UnknownTypeException($type);`
`134`	`133`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ final class Help`
`32`	`32`	`private const LEFT_MARGIN = ' ';`
`33`	`33`	`private int $lengthOfLongestOptionName = 0;`
`34`	`34`	`private readonly int $columnsAvailableForDescription;`
`35`		`- private ?bool $hasColor;`
	`35`	`+ private bool $hasColor;`
`36`	`36`
`37`	`37`	`public function __construct(?int $width = null, ?bool $withColor = null)`
`38`	`38`	`{`