Revert "Add support for default values to getStringAttribute()"

sebastianbergmann · sebastianbergmann · commit 06066c53ad42 · 2022-03-08T09:52:13.000+01:00
This reverts commit 20ff830.
diff --git a/src/TextUI/Configuration/Xml/Loader.php b/src/TextUI/Configuration/Xml/Loader.php
@@ -572,10 +572,10 @@ private function getIntegerAttribute(DOMElement $element, string $attribute, int
         );
     }
 
-    private function getStringAttribute(DOMElement $element, string $attribute, ?string $default = null): ?string
+    private function getStringAttribute(DOMElement $element, string $attribute): ?string
     {
         if (!$element->hasAttribute($attribute)) {
-            return $default ?? null;
+            return null;
         }
 
         return $element->getAttribute($attribute);

Original file line number	Diff line number	Diff line change
`@@ -572,10 +572,10 @@ private function getIntegerAttribute(DOMElement $element, string $attribute, int`
`572`	`572`	`);`
`573`	`573`	`}`
`574`	`574`
`575`		`- private function getStringAttribute(DOMElement $element, string $attribute, ?string $default = null): ?string`
	`575`	`+ private function getStringAttribute(DOMElement $element, string $attribute): ?string`
`576`	`576`	`{`
`577`	`577`	`if (!$element->hasAttribute($attribute)) {`
`578`		`- return $default ?? null;`
	`578`	`+ return null;`
`579`	`579`	`}`
`580`	`580`
`581`	`581`	`return $element->getAttribute($attribute);`