Avoid subprocess when SKIPIF triggers IO

Author: staabm

src/Runner/PHPT/PhptTestCase.php

@@ -432,7 +432,7 @@ private function shouldTestBeSkipped(array $sections, array $settings): bool
 
         $skipIfCode = $this->render($sections['SKIPIF']);
 
-        if ($this->shouldRunSkipIfInSubprocess($sections, $skipIfCode)) {
+        if ($this->shouldRunInSubprocess($sections, $skipIfCode)) {
             $jobResult = JobRunnerRegistry::run(
                 new Job(
                     $skipIfCode,
@@ -469,7 +469,7 @@ private function shouldTestBeSkipped(array $sections, array $settings): bool
     /**
      * @param array<non-empty-string, non-empty-string> $sections
      */
-    private function shouldRunCleanInSubprocess(array $sections, string $cleanCode): bool
+    private function shouldRunInSubprocess(array $sections, string $cleanCode): bool
     {
         if (isset($sections['INI'])) {
             // to get per-test INI settings, we need a dedicated subprocess
@@ -497,35 +497,6 @@ private function shouldRunCleanInSubprocess(array $sections, string $cleanCode):
         return false;
     }
 
-    /**
-     * @param array<non-empty-string, non-empty-string> $sections
-     */
-    private function shouldRunSkipIfInSubprocess(array $sections, string $skipIfCode): bool
-    {
-        if (isset($sections['INI'])) {
-            // to get per-test INI settings, we need a dedicated subprocess
-            return true;
-        }
-
-        $detector    = new SideEffectsDetector;
-        $sideEffects = $detector->getSideEffects($skipIfCode);
-
-        if ($sideEffects === []) {
-            return false; // no side-effects
-        }
-
-        foreach ($sideEffects as $sideEffect) {
-            if ($sideEffect === SideEffect::STANDARD_OUTPUT) {
-                // stdout is fine, we will catch it using output-buffering
-                continue;
-            }
-
-            return true;
-        }
-
-        return false;
-    }
-
     private function runCodeInLocalSandbox(string $code): string
     {
         $code = preg_replace('/^<\?(?:php)?|\?>\s*+$/', '', $code);
@@ -550,7 +521,7 @@ private function runClean(array $sections, bool $collectCoverage): void
 
         $cleanCode = $this->render($sections['CLEAN']);
 
-        if ($this->shouldRunCleanInSubprocess($sections, $cleanCode)) {
+        if ($this->shouldRunInSubprocess($sections, $cleanCode)) {
             $result = JobRunnerRegistry::run(
                 new Job(
                     $cleanCode,

tests/end-to-end/_files/phpt-skipif-io.phpt

@@ -0,0 +1,11 @@
+--TEST--
+PHPT skip condition with IO operations run in main process
+--SKIPIF--
+<?php declare(strict_types=1);
+file_put_contents(__DIR__ . '/skipif-io.log', 'some content');
+unlink(__DIR__ . '/skipif-io.log');
+--FILE--
+<?php declare(strict_types=1);
+echo "Hello, World!\n";
+--EXPECT--
+Hello, World!

tests/end-to-end/event/phpt-skipif-io.phpt

@@ -0,0 +1,31 @@
+--TEST--
+The right events are emitted in the right order for PHPT test using IO in skipif
+--FILE--
+<?php declare(strict_types=1);
+$_SERVER['argv'][] = '--do-not-cache-result';
+$_SERVER['argv'][] = '--no-configuration';
+$_SERVER['argv'][] = '--debug';
+$_SERVER['argv'][] = __DIR__ . '/../_files/phpt-skipif-io.phpt';
+
+require __DIR__ . '/../../bootstrap.php';
+
+(new PHPUnit\TextUI\Application)->run($_SERVER['argv']);
+--EXPECTF--
+PHPUnit Started (PHPUnit %s using %s)
+Test Runner Configured
+Event Facade Sealed
+Test Suite Loaded (1 test)
+Test Runner Started
+Test Suite Sorted
+Test Runner Execution Started (1 test)
+Test Suite Started (%s%ephpt-skipif-io.phpt, 1 test)
+Test Preparation Started (%s%ephpt-skipif-io.phpt)
+Test Prepared (%s%ephpt-skipif-io.phpt)
+Child Process Started
+Child Process Finished
+Test Passed (%s%ephpt-skipif-io.phpt)
+Test Finished (%s%ephpt-skipif-io.phpt)
+Test Suite Finished (%s%ephpt-skipif-io.phpt, 1 test)
+Test Runner Execution Finished
+Test Runner Finished
+PHPUnit Finished (Shell Exit Code: 0)