Fix deprecated Assertion usage

Author: stijn-dejongh

docs/CONTRIBUTING.md

@@ -139,7 +139,7 @@ void givenCheckedWithInvalidData_whenApplyingRule_itIsEvaluatedAsInvalid() {
 
     assertThat(result).is(invalid());
     assertThat(result.rationale())
-            .extracting(Rationale::details).asList()
+            .extracting(Rationale::details).asInstanceOf(LIST)
             .contains(failed("mustn't be blank"));
 }
 ```

pom.xml

@@ -129,9 +129,6 @@
             <artifactId>log4j-slf4j2-impl</artifactId>
             <version>2.24.0</version>
         </dependency>
-
-
-
     </dependencies>
 
     <build>

src/main/java/be/sddevelopment/validation/core/Constraint.java

@@ -17,6 +17,14 @@
  */
 public record Constraint<T>(Predicate<T> rule, String description) {
 
+    /**
+     * Factory method to create a new {@link ConstraintBuilder} instance.
+     *
+     * @param <S>          type of the object onto which the rule can be applied
+     * @param ignoredClass class to be ignored, as this method is only used as a type parameter
+     *                     to create a new instance of the builder
+     * @return a new instance of the {@link ConstraintBuilder} class, able to evaluate a rule on an object of type S
+     */
     public static <S> ConstraintBuilder<S> ruleFor(Class<S> ignoredClass) {
         return new ConstraintBuilder<>();
     }

src/test/java/be/sddevelopment/validation/core/ConstrainedTest.java

@@ -33,7 +33,7 @@ void givenValidData_whenApplyingRule_itsEvaluationIsRemembered() {
 
         assertThat(result).is(valid());
         assertThat(result.rationale())
-                .extracting(Rationale::details).asList()
+                .extracting(Rationale::details).asInstanceOf(LIST)
                 .contains(passed("mustn't be blank"));
     }
 
@@ -47,7 +47,7 @@ void givenInvalidData_whenApplyingRule_itIsEvaluatedAsInvalid() {
 
         assertThat(result).is(invalid());
         assertThat(result.rationale())
-                .extracting(Rationale::details).asList()
+                .extracting(Rationale::details).asInstanceOf(LIST)
                 .contains(failed("mustn't be blank"));
     }
 
@@ -81,7 +81,7 @@ void ifValid_givenTheDateIsValid_CallsTheProvidedConsumer() {
 
         checked.ifValid(consumer::store);
 
-
+        assertThat(consumer.messages()).containsExactly("I am a real String");
     }
 
     @Test
@@ -96,7 +96,7 @@ void guard_failsFastWhenInvalid() {
 
         assertThatExceptionOfType(InvalidObjectException.class)
                 .isThrownBy(constrainedRecord::guard)
-                .extracting(InvalidObjectException::errors).asList()
+                .extracting(InvalidObjectException::errors).asInstanceOf(LIST)
                 .containsExactly("FAIL: [have a first name]");
     }
 

src/test/java/be/sddevelopment/validation/core/ConstraintTest.java

@@ -43,7 +43,7 @@ void rules_areChainable() {
 
         assertThat(result).is(CheckedTestUtils.invalid())
                 .extracting(Constrained::rationale)
-                .extracting(Rationale::details).asList()
+                .extracting(Rationale::details).asInstanceOf(LIST)
                 .contains(passed("Must be filled in"), failed("Be polite"));
     }
 

src/test/java/be/sddevelopment/validation/specs/code_quality/CodeConventionsTest.java

@@ -26,33 +26,33 @@
 class CodeConventionsTest implements WithAssertions {
 
     @ArchTest
-    private final ArchRule no_access_to_standard_streams = NO_CLASSES_SHOULD_ACCESS_STANDARD_STREAMS;
+    static final ArchRule CLASSES_DO_NOT_ACCESS_STANDARD_STREAMS = NO_CLASSES_SHOULD_ACCESS_STANDARD_STREAMS;
 
     @ArchTest
-    void no_access_to_standard_streams_as_method(JavaClasses classes) {
+    void noAccessToStandardStreamsAsMethod(JavaClasses classes) {
         noClasses().should(ACCESS_STANDARD_STREAMS).check(classes);
     }
 
     @ArchTest
-    private final ArchRule no_classes_should_use_field_injection = NO_CLASSES_SHOULD_USE_FIELD_INJECTION;
+    static final ArchRule NO_CLASSES_USE_FIELD_INJECTION = NO_CLASSES_SHOULD_USE_FIELD_INJECTION;
 
     @ArchTest
-    private final ArchRule no_generic_exceptions = NO_CLASSES_SHOULD_THROW_GENERIC_EXCEPTIONS;
+    static final ArchRule NO_GENERIC_EXCEPTION = NO_CLASSES_SHOULD_THROW_GENERIC_EXCEPTIONS;
 
     @ArchTest
-    private final ArchRule no_java_util_logging = NO_CLASSES_SHOULD_USE_JAVA_UTIL_LOGGING;
+    static final ArchRule NO_JAVA_UTIL_LOGGING = NO_CLASSES_SHOULD_USE_JAVA_UTIL_LOGGING;
 
     @ArchTest
-    private final ArchRule no_jodatime = NO_CLASSES_SHOULD_USE_JODATIME;
+    static final ArchRule NO_JODATIME = NO_CLASSES_SHOULD_USE_JODATIME;
 
     @ArchTest
-    private final ArchRule utility_classes_can_not_be_instantiated = noClasses()
+    static final ArchRule UTILITY_CLASSES_CAN_NOT_BE_INSTANTIATED = noClasses()
             .that().haveModifier(FINAL)
             .and().haveSimpleNameNotContaining("Test")
             .and().areNotEnums()
             .should(beInstantiatable());
 
-    private ArchCondition<? super JavaClass> beInstantiatable() {
+    static ArchCondition<? super JavaClass> beInstantiatable() {
         return new ArchCondition<>("be instantiatable") {
             @Override
             public void check(JavaClass item, ConditionEvents events) {
@@ -65,7 +65,7 @@ public void check(JavaClass item, ConditionEvents events) {
         };
     }
 
-    boolean isInstantiatable(JavaClass classToCheck) {
+    static boolean isInstantiatable(JavaClass classToCheck) {
 
         try {
             if (classToCheck.getConstructors().stream()