fix(3225): handling when the webhook is incorrect (#37)

Author: y-oksaku

index.js

@@ -213,7 +213,13 @@ class ScmRouter extends Scm {
             if (!scm) {
                 logger.info('Webhook does not match any expected events or actions.');
 
-                return null;
+                const err = new Error(
+                    'Cannot parse this webhook. Please ensure that the signature is correct or that this SCM is supported.'
+                );
+
+                err.statusCode = 400;
+
+                return Promise.reject(err);
             }
 
             return scm.parseHook(headers, payload);

test/index.test.js

@@ -614,6 +614,25 @@ describe('index test', () => {
                 assert.calledOnce(exampleScm.parseHook);
                 assert.calledWith(exampleScm.parseHook, headers, payload);
             }));
+
+        it('rejects error when all scm cannot parse the webhook', () => {
+            scmGithub.canHandleWebhook.resolves(false);
+            scmGitlab.canHandleWebhook.resolves(false);
+            exampleScm.canHandleWebhook.resolves(false);
+
+            return scm
+                ._parseHook(headers, payload)
+                .then(() => {
+                    assert.fail('This should not fail the tests');
+                })
+                .catch(err => {
+                    assert.include(err.message, 'Cannot parse this webhook');
+                    assert.strictEqual(err.statusCode, 400);
+                    assert.notCalled(scmGithub.parseHook);
+                    assert.notCalled(scmGitlab.parseHook);
+                    assert.notCalled(exampleScm.parseHook);
+                });
+        });
     });
 
     describe('_getCheckoutCommand', () => {