fix: fix for Bitbucket Deprecation of username usage (#68)

Author: xangxiong

index.js

@@ -376,7 +376,18 @@ class BitbucketScm extends Scm {
         const response = await this.breaker.runCommand(options);
         const body = response.body;
 
-        if (response.statusCode !== 200) {
+        if (response.statusCode === 404 && !config.username.match(/^\{.*\}/)) {
+            // Bitbucket API has changed, cannot use strict username request anymore, for now we will
+            // have to return a simple generated decoration result to allow all builds to function.
+            // We will only allow this if the username is not a {uuid} pattern. Since if this is a {uuid}
+            // pattern, this likely is a valid 404.
+            return {
+                url: '',
+                name: config.username,
+                username: config.username,
+                avatar: ''
+            };
+        } else if (response.statusCode !== 200) {
             throw new Error(`STATUS CODE ${response.statusCode}: ${JSON.stringify(body)}`);
         }
 

test/index.test.js

@@ -438,7 +438,42 @@ describe('index', function () {
                 assert.deepEqual(decorated, expected);
             });
         });
+        it('resolves to a fabricated decorated author', () => {
+            fakeResponse = {
+                statusCode: 404,
+                body: {
+                    error: {
+                        message: 'Resource not found',
+                        detail: 'There is no API hosted at this URL'
+                    }
+                }
+            };
+
+            requestMock.yieldsAsync(null, fakeResponse, fakeResponse.body);
+
+            const expected = {
+                url: '',
+                name: 'batman',
+                username: 'batman',
+                avatar: ''
+            };
+            const expectedFabricatedOptions = {
+                url: `${API_URL_V2}/users/batman`,
+                method: 'GET',
+                json: true,
+                auth: {
+                    bearer: systemToken
+                }
+            };
 
+            return scm.decorateAuthor({
+                username: 'batman',
+                token
+            }).then((decorated) => {
+                assert.calledWith(requestMock, expectedFabricatedOptions);
+                assert.deepEqual(decorated, expected);
+            });
+        });
         it('rejects if status code is not 200', () => {
             fakeResponse = {
                 statusCode: 404,