fix: Unify error objects with GitHub errors. (#75)

Author: yuichi10

index.js

@@ -47,13 +47,13 @@ function checkResponseError(response) {
     const errorMessage = hoek.reach(response, 'body.error.message', {
         default: `SCM service unavailable (${response.statusCode}).`
     });
-    const errorReason = hoek.reach(response, 'body.error.detail.required', {
+    const errorReason = hoek.reach(response, 'body.error.detail', {
         default: JSON.stringify(response.body)
     });
 
     const error = new Error(`${errorMessage} Reason "${errorReason}"`);
 
-    error.code = response.statusCode;
+    error.status = response.statusCode;
     throw error;
 }
 
@@ -527,10 +527,7 @@ class BitbucketScm extends Scm {
 
         const response = await this.breaker.runCommand(options);
 
-        if (response.statusCode !== 200) {
-            throw new Error(
-                `STATUS CODE ${response.statusCode}: ${JSON.stringify(response.body)}`);
-        }
+        checkResponseError(response);
 
         return response.body.target.hash;
     }

package.json

@@ -42,8 +42,8 @@
     "mocha": "^8.2.1",
     "mocha-multi-reporters": "^1.5.1",
     "mocha-sonarqube-reporter": "^1.0.2",
-    "nyc": "^15.0.0",
     "mockery": "^2.0.0",
+    "nyc": "^15.0.0",
     "sinon": "^4.5.0"
   },
   "dependencies": {

test/index.test.js

@@ -857,7 +857,9 @@ describe('index', function () {
                 assert.fail('Should not get here');
             }).catch((error) => {
                 assert.calledWith(requestMock, expectedOptions);
-                assert.match(error.message, 'STATUS CODE 404');
+                assert.match(error.message, 'Resource not found Reason ' +
+                    '"There is no API hosted at this URL"');
+                assert.match(error.status, 404);
             });
         });
 
@@ -1744,10 +1746,7 @@ describe('index', function () {
                 type: 'error',
                 error: {
                     message: 'Your credentials lack one or more required privilege scopes.',
-                    detail: {
-                        granted: ['repository'],
-                        required: ['webhook']
-                    }
+                    detail: 'webhook'
                 }
             };
 
@@ -1771,6 +1770,7 @@ describe('index', function () {
                 ]
             }).then(assert.fail, (err) => {
                 assert.strictEqual(err.message, expectedMessage);
+                assert.strictEqual(err.status, 403);
             });
         });
 
@@ -1806,10 +1806,7 @@ describe('index', function () {
                 type: 'error',
                 error: {
                     message: 'Your credentials lack one or more required privilege scopes.',
-                    detail: {
-                        granted: ['repository'],
-                        required: ['webhook']
-                    }
+                    detail: 'webhook'
                 }
             };
 
@@ -1855,10 +1852,7 @@ describe('index', function () {
                 type: 'error',
                 error: {
                     message: 'Your credentials lack one or more required privilege scopes.',
-                    detail: {
-                        granted: ['repository'],
-                        required: ['webhook']
-                    }
+                    detail: 'webhook'
                 }
             };