fix(3384): Failure to get user info from scm should not throw error (#101)

Author: sagar1312

index.js

@@ -3,11 +3,20 @@
 /* eslint-disable no-underscore-dangle */
 const Hoek = require('@hapi/hoek');
 const Joi = require('joi');
+const logger = require('screwdriver-logger');
 const dataSchema = require('screwdriver-data-schema');
 const { getAnnotations } = require('./lib/helper');
 
 const repoManifestAnnotation = 'screwdriver.cd/repoManifest';
 
+const DEFAULT_AUTHOR = {
+    id: '',
+    avatar: 'https://cd.screwdriver.cd/assets/unknown_user.png',
+    name: 'n/a',
+    username: 'n/a',
+    url: 'https://cd.screwdriver.cd/'
+};
+
 /**
  * Validate the config using the schema
  * @method  validate
@@ -328,7 +337,23 @@ class ScmBase {
      */
     decorateAuthor(config) {
         return validate(config, dataSchema.plugins.scm.decorateAuthor)
-            .then(validAuthor => this._decorateAuthor(this.getConfig(validAuthor)))
+            .then(async validAuthor => {
+                let author;
+
+                try {
+                    author = await this._decorateAuthor(this.getConfig(validAuthor));
+                } catch (err) {
+                    logger.error('Failed to decorateAuthor: ', err);
+
+                    author = {
+                        ...DEFAULT_AUTHOR,
+                        name: config.username,
+                        username: config.username
+                    };
+                }
+
+                return author;
+            })
             .then(decoratedAuthor => validate(decoratedAuthor, dataSchema.core.scm.user));
     }
 

package.json

@@ -47,6 +47,7 @@
   "dependencies": {
     "@hapi/hoek": "^11.0.7",
     "joi": "^17.13.3",
-    "screwdriver-data-schema": "^25.0.0"
+    "screwdriver-data-schema": "^25.0.0",
+    "screwdriver-logger": "^3.0.0"
   }
 }

test/index.test.js

@@ -596,12 +596,38 @@ describe('index test', () => {
         it('returns not implemented', () =>
             instance
                 .decorateAuthor(config)
-                .then(() => {
-                    assert.fail('you will never get dis');
+                .then(author => {
+                    assert.deepEqual(
+                        {
+                            id: '',
+                            avatar: 'https://cd.screwdriver.cd/assets/unknown_user.png',
+                            name: config.username,
+                            username: config.username,
+                            url: 'https://cd.screwdriver.cd/'
+                        },
+                        author
+                    );
                 })
                 .catch(err => {
                     assert.equal(err.message, 'Not implemented');
                 }));
+
+        it('returns default author when there is a failure get author from scm', () => {
+            instance._decorateAuthor = () => Promise.reject(new Error('User profile does not exist'));
+
+            return instance.decorateAuthor(config).then(author => {
+                assert.deepEqual(
+                    {
+                        id: '',
+                        avatar: 'https://cd.screwdriver.cd/assets/unknown_user.png',
+                        name: config.username,
+                        username: config.username,
+                        url: 'https://cd.screwdriver.cd/'
+                    },
+                    author
+                );
+            });
+        });
     });
 
     describe('getPermissons', () => {