Skip to content

Commit f4edaea

Browse files
authored
Merge pull request #29 from screwdriver-cd/DataSchema
fix(399): Catching up to new version of `data-schema`
2 parents 871ecd1 + b9a4d05 commit f4edaea

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "screwdriver-executor-base",
3-
"version": "5.1.0",
3+
"version": "5.2.0",
44
"description": "Base class defining the interface for executor implementations",
55
"main": "index.js",
66
"scripts": {
@@ -40,11 +40,11 @@
4040
"chai": "^3.5.0",
4141
"eslint": "^3.4.0",
4242
"eslint-config-screwdriver": "^2.0.0",
43-
"jenkins-mocha": "^3.0.0",
43+
"jenkins-mocha": "^4.0.0",
4444
"mockery": "^2.0.0"
4545
},
4646
"dependencies": {
4747
"joi": "^10.0.5",
48-
"screwdriver-data-schema": "^15.0.3"
48+
"screwdriver-data-schema": "^16.0.0"
4949
}
5050
}

test/index.test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,18 +114,18 @@ describe('index test', () => {
114114

115115
it('can be extended', () => {
116116
class Foo extends Executor {
117-
_stop(config, callback) {
118-
return callback(null, config);
117+
_stop(config) {
118+
return Promise.resolve(config);
119119
}
120120
}
121121

122122
const bar = new Foo({ foo: 'bar' });
123123

124124
assert.instanceOf(bar, Executor);
125-
bar.stop({
125+
126+
return bar.stop({
126127
buildId: 'a'
127-
}, (err, data) => {
128-
assert.isNull(err);
128+
}).then((data) => {
129129
assert.equal(data.buildId, 'a');
130130
});
131131
});

0 commit comments

Comments
 (0)