fix(1030): Not to exchange token if it is already the build token (#44)

Author: sakka2

index.js

@@ -5,6 +5,7 @@ const Joi = require('joi');
 const dataSchema = require('screwdriver-data-schema');
 const executorSchema = dataSchema.plugins.executor;
 const request = require('requestretry');
+const jwt = require('jsonwebtoken');
 const DEFAULT_BUILD_TIMEOUT = 90; // in minutes
 
 /**
@@ -24,6 +25,18 @@ async function validate(config, schema) {
     return config;
 }
 
+/**
+ * Check if the scope of jwt is temporal or not
+ * @async  isTemporalJwt
+ * @param  {String}  token Jwt
+ * @return {Boolean}
+ */
+function isTemporalJwt(token) {
+    const decoded = jwt.decode(token);
+
+    return decoded.scope.includes('temporal');
+}
+
 class Executor {
     /**
      * Constructor for Executor
@@ -135,6 +148,11 @@ class Executor {
      * @return {Promise}
      */
     async exchangeTokenForBuild(config, buildTimeout = DEFAULT_BUILD_TIMEOUT) {
+        // Use token directly if the scope is already 'build' (#1030)
+        if (!isTemporalJwt(config.token)) {
+            return config.token;
+        }
+
         if (isFinite(buildTimeout) === false) {
             throw new Error(`Invalid buildTimeout value: ${buildTimeout}`);
         }

package.json

@@ -46,6 +46,7 @@
   },
   "dependencies": {
     "joi": "^13.0.0",
+    "jsonwebtoken": "^8.2.2",
     "requestretry": "^1.13.0",
     "screwdriver-data-schema": "^18.20.0"
   }

test/index.test.js

@@ -4,6 +4,7 @@ const { assert } = require('chai');
 const sinon = require('sinon');
 const mockery = require('mockery');
 const Joi = require('joi');
+const jwt = require('jsonwebtoken');
 const DEFAULT_BUILD_TIMEOUT = 90; // in minutes
 
 describe('index test', () => {
@@ -164,12 +165,14 @@ describe('index test', () => {
         let options;
         let buildTimeout;
         let fakeResponse;
+        let token;
 
         beforeEach(() => {
+            token = jwt.sign({ scope: ['temporal'] }, 'dummyPrivateKey');
             postConfig = {
                 buildId: 111,
                 apiUri: 'https://dummy.com',
-                token: 'dummyTemporalToken'
+                token
             };
             buildTimeout = 150;
             options = {
@@ -205,6 +208,15 @@ describe('index test', () => {
             });
         });
 
+        it('does not exchange and return token as it is if it is already build JWT', async () => {
+            token = jwt.sign({ scope: ['build'] }, 'dummyPrivateKey');
+            postConfig.token = token;
+
+            await instance.exchangeTokenForBuild(postConfig).then((buildToken) => {
+                assert.equal(postConfig.token, buildToken);
+            });
+        });
+
         it('returns error if buildTimeout value is invalid', async () => {
             buildTimeout = 'aaa';
             const returnMessage = `Invalid buildTimeout value: ${buildTimeout}`;