Skip to content

Commit 1c8c613

Browse files
committed
refactors type hints for optional parameters
Updates type hints for optional parameters to use `Optional` instead of `Dict[str, Any] | None` for better readability and consistency.
1 parent b8b4970 commit 1c8c613

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

src/screenshotmax/client.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import hmac
22
import hashlib
3-
from typing import Any, Dict, Tuple
3+
from typing import Any, Dict, Optional, Tuple
44
import requests
55

66

@@ -22,24 +22,24 @@ def _compute_query(self, obj: Dict[str, Any]) -> str:
2222
filtered = {k: str(v) for k, v in obj.items() if v is not None}
2323
return urlencode(filtered)
2424

25-
def generate_url(self, path: str, params: Dict[str, Any] | None = None) -> str:
25+
def generate_url(self, path: str, params: Optional[Dict[str, Any]] = None) -> str:
2626
params = params or {}
2727
query = self._compute_query({**params, "access_key": self.access_key})
2828
return f"{self.base_url}{path}?{query}"
2929

30-
def generate_signed_url(self, path: str, params: Dict[str, Any] | None = None) -> str:
30+
def generate_signed_url(self, path: str, params: Optional[Dict[str, Any]] = None) -> str:
3131
params = params or {}
3232
query = self._compute_query({**params, "access_key": self.access_key})
3333
signature = self._sign_request(query)
3434
return f"{self.base_url}{path}?{query}&signature={signature}"
3535

36-
def get(self, path: str, options: Dict[str, Any] | None = None, signed: bool = False,
36+
def get(self, path: str, options: Optional[Dict[str, Any]] = None, signed: bool = False,
3737
**request_kwargs: Any) -> Tuple[Any, Dict[str, Any]]:
3838
url = self.generate_signed_url(path, options) if signed else self.generate_url(path, options)
3939
response = requests.get(url, **request_kwargs)
4040
return response.content, dict(response.headers)
4141

42-
def post(self, path: str, options: Dict[str, Any] | None = None, **request_kwargs: Any) -> Tuple[Any, Dict[str, Any]]:
42+
def post(self, path: str, options: Optional[Dict[str, Any]] = None, **request_kwargs: Any) -> Tuple[Any, Dict[str, Any]]:
4343
url = f"{self.base_url}{path}"
4444
headers = {"X-Access-Key": self.access_key, **request_kwargs.pop("headers", {})}
4545
response = requests.post(url, json=options or {}, headers=headers, **request_kwargs)
@@ -51,7 +51,7 @@ def delete(self, path: str, **request_kwargs: Any) -> Any:
5151
response = requests.delete(url, headers=headers, **request_kwargs)
5252
return response.json()
5353

54-
def patch(self, path: str, options: Dict[str, Any] | None = None, **request_kwargs: Any) -> Any:
54+
def patch(self, path: str, options: Optional[Dict[str, Any]] = None, **request_kwargs: Any) -> Any:
5555
url = f"{self.base_url}{path}"
5656
headers = {"X-Access-Key": self.access_key, **request_kwargs.pop("headers", {})}
5757
response = requests.patch(url, json=options or {}, headers=headers, **request_kwargs)

src/screenshotmax/services/pdf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Any, Dict, Tuple
1+
from typing import Any, Dict, Optional, Tuple
22
from ..client import APIClient
33
from ..options import PDFOptions
44

@@ -8,7 +8,7 @@ class PDFService:
88

99
def __init__(self, client: APIClient) -> None:
1010
self.client = client
11-
self._options: PDFOptions | None = None
11+
self._options: Optional[PDFOptions] = None
1212
self._request_kwargs = {
1313
"stream": True
1414
}

src/screenshotmax/services/scrape.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Any, Dict, Tuple
1+
from typing import Any, Dict, Optional, Tuple
22
from ..client import APIClient
33
from ..options import ScrapeOptions
44

@@ -8,7 +8,7 @@ class ScrapeService:
88

99
def __init__(self, client: APIClient) -> None:
1010
self.client = client
11-
self._options: ScrapeOptions | None = None
11+
self._options: Optional[ScrapeOptions] = None
1212

1313
def set_options(self, options: ScrapeOptions) -> "ScrapeService":
1414
self._options = options

src/screenshotmax/services/screencast.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Any, Dict, Tuple
1+
from typing import Any, Dict, Optional, Tuple
22
from ..client import APIClient
33
from ..options import ScreencastOptions
44

@@ -8,7 +8,7 @@ class ScreencastService:
88

99
def __init__(self, client: APIClient) -> None:
1010
self.client = client
11-
self._options: ScreencastOptions | None = None
11+
self._options: Optional[ScreencastOptions] = None
1212
self._request_kwargs = {
1313
"stream": True
1414
}

src/screenshotmax/services/screenshot.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Any, Dict, Tuple
1+
from typing import Any, Dict, Optional, Tuple
22
from ..client import APIClient
33
from ..options import ScreenshotOptions
44

@@ -8,7 +8,7 @@ class ScreenshotService:
88

99
def __init__(self, client: APIClient) -> None:
1010
self.client = client
11-
self._options: ScreenshotOptions | None = None
11+
self._options: Optional[ScreenshotOptions] = None
1212
self._request_kwargs = {
1313
"stream": True
1414
}

0 commit comments

Comments
 (0)