Skip to content

Commit 70a36d9

Browse files
committed
refactor(_module): {_module => _comp_cmd_module__compgen}_*
1 parent 5a5c62d commit 70a36d9

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

completions/_modules

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,30 +21,26 @@
2121
# being sourced before it and thus before the `module' alias has been defined.
2222
[[ -f /etc/profile.d/modules.sh ]] || return 1
2323

24-
# TODO:API: rename per conventions, rework to use vars rather than outputting
25-
_module_list()
24+
_comp_cmd_module__compgen_list()
2625
{
2726
local modules="$(command sed 's/:/ /g' <<<"$LOADEDMODULES" | sort)"
28-
compgen -W "$modules" -- "$1"
27+
_comp_compgen -- -W "$modules"
2928
}
3029

31-
# TODO:API: rename per conventions, rework to use vars rather than outputting
32-
_module_path()
30+
_comp_cmd_module__compgen_path()
3331
{
3432
local modules="$(command sed 's/:/ /g' <<<"$MODULEPATH" | sort)"
35-
compgen -W "$modules" -- "$1"
33+
_comp_compgen -- -W "$modules"
3634
}
3735

38-
# TODO:API: rename per conventions, rework to use vars rather than outputting
39-
_module_avail()
36+
_comp_cmd_module__compgen_avail()
4037
{
4138
local modules="$(
4239
module avail 2>&1 |
4340
command grep -E -v '^(-|$)' |
4441
xargs printf '%s\n' | command sed -e 's/(default)//g' | sort
4542
)"
46-
47-
compgen -W "$modules" -- "$1"
43+
_comp_compgen -- -W "$modules"
4844
}
4945

5046
# A completion function for the module alias
@@ -65,19 +61,23 @@ _comp_cmd_module()
6561
elif ((cword == 2)); then
6662
case $prev in
6763
add | display | help | load | show | whatis)
68-
COMPREPLY=($(_module_avail "$cur"))
64+
# TODO:API: use generator call?
65+
_comp_cmd_module__compgen_avail
6966
;;
7067
rm | switch | swap | unload | update)
71-
COMPREPLY=($(_module_list "$cur"))
68+
# TODO:API: use generator call?
69+
_comp_cmd_module__compgen_list
7270
;;
7371
unuse)
74-
COMPREPLY=($(_module_path "$cur"))
72+
# TODO:API: use generator call?
73+
_comp_cmd_module__compgen_path
7574
;;
7675
esac
7776
elif ((cword == 3)); then
7877
case ${words[1]} in
7978
swap | switch)
80-
COMPREPLY=($(_module_avail "$cur"))
79+
# TODO:API: use generator call?
80+
_comp_cmd_module__compgen_avail
8181
;;
8282
esac
8383
fi

0 commit comments

Comments
 (0)