refactor(modprobe): deprecate in favor of upstream one in >= 35

evelikov · evelikov · commit 66a52b0e9bc1 · 2024-11-08T16:26:18.000Z
There isn't an equivalent merged upstream, yet, so use "expected to" wording. Issue: #1246 Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
diff --git a/completions/Makefile.am b/completions/Makefile.am
@@ -269,7 +269,7 @@ bashcomp_DATA = 2to3 \
 		mmsitepass \
 		_mock \
 		_modinfo \
-		modprobe \
+		_modprobe \
 		_modules \
 		monodevelop \
 		_mount \
diff --git a/completions/_modprobe b/completions/_modprobe
@@ -1,5 +1,8 @@
 # Linux modprobe(8) completion                             -*- shell-script -*-
 
+# Use of this file is deprecated.
+# Upstream completion is expected to be available in kmod >= 35, use that instead.
+
 _comp_cmd_modprobe()
 {
     local cur prev words cword was_split comp_args
diff --git a/test/fallback/completions/Makefile.am b/test/fallback/completions/Makefile.am
@@ -23,6 +23,7 @@ EXTRA_DIST = \
 	mock \
 	modinfo \
 	modules \
+	modprobe \
 	mount \
 	mount.linux \
 	newgrp \
diff --git a/test/fallback/completions/modprobe b/test/fallback/completions/modprobe
@@ -0,0 +1 @@
+../../../completions/_modprobe

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,8 @@`
`1`	`1`	`# Linux modprobe(8) completion -- shell-script --`
`2`	`2`
	`3`	`+# Use of this file is deprecated.`
	`4`	`+# Upstream completion is expected to be available in kmod >= 35, use that instead.`
	`5`	`+`
`3`	`6`	`_comp_cmd_modprobe()`
`4`	`7`	`{`
`5`	`8`	`local cur prev words cword was_split comp_args`