FIX GaussianMixture sample method to correctly handle mps (scikit-learn#31639)

OmarManzoor · ogrisel · web-flow · commit 4daff41cdda3 · 2025-06-26T13:15:00.000+05:00
Co-authored-by: Olivier Grisel &lt;olivier.grisel@ensta.org&gt;
diff --git a/sklearn/mixture/_base.py b/sklearn/mixture/_base.py
@@ -20,6 +20,7 @@
     _convert_to_numpy,
     _is_numpy_namespace,
     _logsumexp,
+    _max_precision_float_dtype,
     get_namespace,
     get_namespace_and_device,
 )
@@ -504,7 +505,8 @@ def sample(self, n_samples=1):
             ]
         )
 
-        return xp.asarray(X, device=device_), y
+        max_float_dtype = _max_precision_float_dtype(xp=xp, device=device_)
+        return xp.asarray(X, dtype=max_float_dtype, device=device_), y
 
     def _estimate_weighted_log_prob(self, X, xp=None):
         """Estimate the weighted log-probabilities, log P(X | Z) + log weights.

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`_convert_to_numpy,`
`21`	`21`	`_is_numpy_namespace,`
`22`	`22`	`_logsumexp,`
	`23`	`+ _max_precision_float_dtype,`
`23`	`24`	`get_namespace,`
`24`	`25`	`get_namespace_and_device,`
`25`	`26`	`)`
`@@ -504,7 +505,8 @@ def sample(self, n_samples=1):`
`504`	`505`	`]`
`505`	`506`	`)`
`506`	`507`
`507`		`- return xp.asarray(X, device=device_), y`
	`508`	`+ max_float_dtype = _max_precision_float_dtype(xp=xp, device=device_)`
	`509`	`+ return xp.asarray(X, dtype=max_float_dtype, device=device_), y`
`508`	`510`
`509`	`511`	`def _estimate_weighted_log_prob(self, X, xp=None):`
`510`	`512`	`"""Estimate the weighted log-probabilities, log P(X \| Z) + log weights.`