refactor: Use urllib.parse.urlsplit over urlparse (#1997)

* Use urllib.parse.urlsplit over urllib.parse.urlparse to avoid having to deal with
  urlparse's 'params' argument which incurs a performance cost.
   - c.f. https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlsplit
   - c.f. https://youtu.be/ABJvdsIANds

Author: matthewfeickert

src/pyhf/contrib/utils.py

@@ -6,7 +6,7 @@
 from io import BytesIO
 from pathlib import Path
 from shutil import rmtree
-from urllib.parse import urlparse
+from urllib.parse import urlsplit
 
 from pyhf import exceptions
 
@@ -50,7 +50,7 @@ def download(archive_url, output_directory, force=False, compress=False):
         """
         if not force:
             valid_hosts = ["www.hepdata.net", "doi.org"]
-            netloc = urlparse(archive_url).netloc
+            netloc = urlsplit(archive_url).netloc
             if netloc not in valid_hosts:
                 raise exceptions.InvalidArchiveHost(
                     f"{netloc} is not an approved archive host: {', '.join(str(host) for host in valid_hosts)}\n"