File tree Expand file tree Collapse file tree 3 files changed +11
-6
lines changed Expand file tree Collapse file tree 3 files changed +11
-6
lines changed Original file line number Diff line number Diff line change @@ -229,12 +229,9 @@ class App extends React.Component {
229
229
var families_checks ;
230
230
try {
231
231
families_checks = pyodide . runPython ( `
232
- from pyodide.http import open_url
233
232
from repo_review.processor import process, md_as_html
234
233
from repo_review.ghpath import GHPath
235
234
236
- GHPath.open_url = staticmethod(open_url)
237
-
238
235
package = GHPath(repo="${ state . repo } ", branch="${ state . branch } ")
239
236
result = process(package)
240
237
Original file line number Diff line number Diff line change @@ -113,8 +113,9 @@ disallow_untyped_defs = true
113
113
114
114
115
115
[tool .pylint ]
116
- master.py-version = " 3.10"
117
- master.ignore-paths = [" src/repo_review/_version.py" ]
116
+ py-version = " 3.10"
117
+ ignore-paths = [" src/repo_review/_version.py" ]
118
+ ignored-modules = [" pyodide" ]
118
119
reports.output-format = " colorized"
119
120
similarities.ignore-imports = " yes"
120
121
messages_control.disable = [
@@ -131,6 +132,7 @@ messages_control.disable = [
131
132
" no-member" , # better handled by mypy, etc.
132
133
" used-before-assignment" , # False positive on conditional import
133
134
" unnecessary-ellipsis" , # Not correct for typing
135
+ " import-outside-toplevel" , # better handled elsewhere
134
136
]
135
137
136
138
Original file line number Diff line number Diff line change 7
7
import dataclasses
8
8
import io
9
9
import json
10
+ import sys
10
11
import typing
11
12
from collections .abc import Iterator
12
13
from typing import Literal
@@ -47,7 +48,12 @@ class GHPath(Traversable):
47
48
48
49
@staticmethod
49
50
def open_url (url : str ) -> io .StringIO :
50
- "This method can be overridden for pyodide with pyodide.open_url"
51
+ "This method can be overridden manually for WASM. Supports pyodide currently."
52
+ if sys .platform == "emscripten" :
53
+ import pyodide .http
54
+
55
+ return pyodide .http .open_url (url )
56
+
51
57
import urllib .request # pylint: disable=import-outside-toplevel
52
58
53
59
with urllib .request .urlopen (url ) as response :
You can’t perform that action at this time.
0 commit comments