fix: commit activity comes in oldest first from github

Author: schaermu

scoring/commit_activity_scorer.go

@@ -15,7 +15,9 @@ type CommitActivityScorer struct {
 
 func (s CommitActivityScorer) GetScore(currentScore float64, penalties []ScoringPenalty) (float64, []ScoringPenalty) {
 	weeksWithoutActivity := 0
-	for _, commit := range s.data.CommitActivity {
+	// loop in reverse because we get oldest first from github
+	for i := len(s.data.CommitActivity) - 1; i >= 0; i-- {
+		commit := s.data.CommitActivity[i]
 		if commit.GetTotal() == 0 {
 			weeksWithoutActivity++
 		} else {

scoring/commit_activity_scorer_test.go

@@ -12,18 +12,18 @@ import (
 )
 
 func getTestCommitActivityData(inactiveWeekCount int) []*github.WeeklyCommitActivity {
-	// prepare commit activity data
+	// prepare commit activity data: first an active week, then append inactive ones (we loop in reverse)
 	activity := make([]*github.WeeklyCommitActivity, 0)
+	one := 1
+	firstActiveTime := github.Timestamp{Time: time.Now().Local().AddDate(0, 0, -7*inactiveWeekCount+2)}
+	activity = append(activity, &github.WeeklyCommitActivity{Week: &firstActiveTime, Total: &one})
 	if inactiveWeekCount > 0 {
 		zero := 0
 		for i := 1; i < inactiveWeekCount+1; i++ {
 			time := github.Timestamp{Time: time.Now().Local().AddDate(0, 0, -7*i)}
 			activity = append(activity, &github.WeeklyCommitActivity{Week: &time, Total: &zero})
 		}
 	}
-	one := 1
-	firstActiveTime := github.Timestamp{Time: time.Now().Local().AddDate(0, 0, -7*inactiveWeekCount+2)}
-	activity = append(activity, &github.WeeklyCommitActivity{Week: &firstActiveTime, Total: &one})
 	return activity
 }