Fix nil pointer dereference in ensureExtraLBs

Tomy2e · Tomy2e · commit fdb5eeb273a1 · 2025-06-12T16:28:02.000+02:00
diff --git a/internal/service/scaleway/lb/lb.go b/internal/service/scaleway/lb/lb.go
@@ -243,7 +243,7 @@ func getLBIPv4(lb *lb.LB) (string, error) {
 func (s *Service) ensureExtraLBs(ctx context.Context, delete bool) ([]*lb.LB, error) {
 	var desired []infrav1.LoadBalancerSpec
 	// When delete is set, we ensure an empty list of LBs to remove everything.
-	if !delete {
+	if !delete && s.ScalewayCluster.Spec.Network != nil {
 		desired = s.ScalewayCluster.Spec.Network.ControlPlaneExtraLoadBalancers
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ func getLBIPv4(lb *lb.LB) (string, error) {`
`243`	`243`	`func (s Service) ensureExtraLBs(ctx context.Context, delete bool) ([]lb.LB, error) {`
`244`	`244`	`var desired []infrav1.LoadBalancerSpec`
`245`	`245`	`// When delete is set, we ensure an empty list of LBs to remove everything.`
`246`		`- if !delete {`
	`246`	`+ if !delete && s.ScalewayCluster.Spec.Network != nil {`
`247`	`247`	`desired = s.ScalewayCluster.Spec.Network.ControlPlaneExtraLoadBalancers`
`248`	`248`	`}`
`249`	`249`