fix check_all_scene_paths_remote and make test scene more complex

Author: Drew Kaul

nucleus/constants.py

@@ -41,6 +41,7 @@
 HEIGHT_KEY = "height"
 IGNORED_ITEMS = "ignored_items"
 IMAGE_KEY = "image"
+IMAGE_LOCATION_KEY = "image_location"
 IMAGE_URL_KEY = "image_url"
 INDEX_KEY = "index"
 ITEMS_KEY = "items"

nucleus/scene.py

@@ -7,6 +7,7 @@
     METADATA_KEY,
     REFERENCE_ID_KEY,
     POINTCLOUD_LOCATION_KEY,
+    IMAGE_LOCATION_KEY,
 )
 from .annotation import is_local_path
 from .dataset_item import DatasetItemType, DatasetItem
@@ -174,8 +175,15 @@ def check_all_scene_paths_remote(scenes: List[LidarScene]):
     for scene in scenes:
         for frame in scene.frames_dict.values():
             for item in frame.items.values():
-                if is_local_path(getattr(item, POINTCLOUD_LOCATION_KEY)):
+                pointcloud_location = getattr(item, POINTCLOUD_LOCATION_KEY)
+                if pointcloud_location and is_local_path(pointcloud_location):
                     raise ValueError(
-                        f"All paths for DatasetItems in a Scene must be remote, but {item.url} is either "
+                        f"All paths for DatasetItems in a Scene must be remote, but {item.pointcloud_location} is either "
+                        "local, or a remote URL type that is not supported."
+                    )
+                image_location = getattr(item, IMAGE_LOCATION_KEY)
+                if image_location and is_local_path(image_location):
+                    raise ValueError(
+                        f"All paths for DatasetItems in a Scene must be remote, but {item.image_location} is either "
                         "local, or a remote URL type that is not supported."
                     )

tests/helpers.py

@@ -37,6 +37,25 @@
                         "reference_id": "lidar_frame_1",
                         "metadata": {},
                     },
+                    "camera": {
+                        "image_url": TEST_IMG_URLS[0],
+                        "reference_id": "camera_frame_1",
+                        "metadata": {
+                            "camera_params": {
+                                "position": {"x": 0, "y": 0, "z": 0},
+                                "heading": {
+                                    "w": 0.6,
+                                    "x": -0.6,
+                                    "y": 0.3,
+                                    "z": -0.3,
+                                },
+                                "fx": 1000,
+                                "fy": 1000,
+                                "cx": 1000,
+                                "cy": 500,
+                            }
+                        },
+                    },
                 }
             ],
             "metadata": {},