Skip to content

Commit 934e22a

Browse files
author
Diego Ardila
committed
Don't install jupyterlab in CI + urllibparse
1 parent fcc648f commit 934e22a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
command: | # install dependencies
1414
pip install --upgrade pip
1515
pip install poetry
16-
poetry install
16+
poetry install --no-dev
1717
- run:
1818
name: Black Formatting Check # Only validation, without re-formatting
1919
command: |

nucleus/dataset_item.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import os.path
44
from dataclasses import dataclass
55
from typing import Optional, Sequence
6+
from urllib.parse import urlparse
67

78
from .constants import (
89
DATASET_ITEM_ID_KEY,
@@ -55,8 +56,7 @@ def to_json(self) -> str:
5556

5657

5758
def is_local_path(path: str) -> bool:
58-
path_components = [comp.lower() for comp in path.split("/")]
59-
return path_components[0] not in {"https:", "http:", "s3:", "gs:"}
59+
return urlparse(path).scheme not in {"https", "http", "s3", "gs"}
6060

6161

6262
def check_all_paths_remote(dataset_items: Sequence[DatasetItem]):

0 commit comments

Comments
 (0)