fix item_id bug in CuboidAnnotation class

Author: Drew Kaul

nucleus/annotation.py

@@ -295,19 +295,23 @@ def from_json(cls, payload: dict):
         )
 
     def to_payload(self) -> dict:
-        return {
+        payload = {
             LABEL_KEY: self.label,
             TYPE_KEY: CUBOID_TYPE,
             GEOMETRY_KEY: {
                 POSITION_KEY: self.position.to_payload(),
                 DIMENSIONS_KEY: self.dimensions.to_payload(),
                 YAW_KEY: self.yaw,
             },
-            REFERENCE_ID_KEY: self.reference_id,
-            ITEM_ID_KEY: self.item_id,
-            ANNOTATION_ID_KEY: self.annotation_id,
-            METADATA_KEY: self.metadata,
         }
+        if self.reference_id:
+            payload[REFERENCE_ID_KEY] = self.reference_id
+        if self.annotation_id:
+            payload[ANNOTATION_ID_KEY] = self.annotation_id
+        if self.metadata:
+            payload[METADATA_KEY] = self.metadata
+
+        return payload
 
 
 def is_local_path(path: str) -> bool:

tests/test_scene.py

@@ -87,8 +87,7 @@ def test_scene_and_cuboid_upload_sync(dataset):
     lidar_item_ref = payload[SCENES_KEY][0][FRAMES_KEY][0]["lidar"][
         REFERENCE_ID_KEY
     ]
-    lidar_item = dataset.refloc(lidar_item_ref)[ITEM_KEY]
-    TEST_CUBOID_ANNOTATIONS[0][DATASET_ITEM_ID_KEY] = lidar_item.item_id
+    TEST_CUBOID_ANNOTATIONS[0][REFERENCE_ID_KEY] = lidar_item_ref
 
     annotations = [CuboidAnnotation.from_json(TEST_CUBOID_ANNOTATIONS[0])]
     response = dataset.annotate(annotations)
@@ -97,12 +96,10 @@ def test_scene_and_cuboid_upload_sync(dataset):
     assert response["annotations_processed"] == len(annotations)
     assert response["annotations_ignored"] == 0
 
-    response = dataset.loc(annotations[0].item_id)[ANNOTATIONS_KEY]["cuboid"]
-    assert len(response) == 1
-    response_annotation = response[0]
+    response_annotations = dataset.refloc(lidar_item_ref)[ANNOTATIONS_KEY][
+        "cuboid"
+    ]
+    assert len(response_annotations) == 1
     assert_cuboid_annotation_matches_dict(
-        response_annotation, TEST_CUBOID_ANNOTATIONS[0]
+        response_annotations[0], TEST_CUBOID_ANNOTATIONS[0]
     )
-
-    lidar_item_ann = dataset.refloc(lidar_item_ref)[ANNOTATIONS_KEY]["cuboid"]
-    assert annotations == lidar_item_ann