Add unit test for dataset append

Author: rkaplan

tests/test_dataset.py

@@ -1,10 +1,26 @@
 import pytest
 
-import nucleus
-from nucleus import Dataset
+from pathlib import Path
+
+from nucleus import Dataset, DatasetItem, UploadResponse
+from nucleus.constants import (
+    NEW_ITEMS,
+    UPDATED_ITEMS,
+    IGNORED_ITEMS,
+    ERROR_ITEMS,
+    ERROR_PAYLOAD,
+    DATASET_ID_KEY,
+)
 
 
 TEST_DATASET_NAME = '[PyTest] Test Dataset'
+TEST_IMG_URLS = [
+    's3://scaleapi-attachments/BDD/BDD/bdd100k/images/100k/train/6dd63871-831611a6.jpg',
+    's3://scaleapi-attachments/BDD/BDD/bdd100k/images/100k/train/82c1005c-e2d1d94f.jpg',
+    's3://scaleapi-attachments/BDD/BDD/bdd100k/images/100k/train/7f2e1814-6591087d.jpg',
+    's3://scaleapi-attachments/BDD/BDD/bdd100k/images/100k/train/06924f46-1708b96f.jpg',
+    's3://scaleapi-attachments/BDD/BDD/bdd100k/images/100k/train/89b42832-10d662f4.jpg',
+]
 
 @pytest.fixture(scope='module')
 def dataset(CLIENT):
@@ -27,3 +43,43 @@ def test_dataset_create_and_delete(CLIENT):
     # Deletion
     response = CLIENT.delete_dataset(ds.id)
     assert response == {}
+
+
+def test_dataset_append(dataset):
+    def check_is_expected_response(response):
+        assert isinstance(response, UploadResponse)
+        resp_json = response.json()
+        assert resp_json[DATASET_ID_KEY] == dataset.id
+        assert resp_json[NEW_ITEMS] == len(TEST_IMG_URLS)
+        assert resp_json[UPDATED_ITEMS] == 0
+        assert resp_json[IGNORED_ITEMS] == 0
+        assert resp_json[ERROR_ITEMS] == 0
+        assert ERROR_PAYLOAD not in resp_json
+
+    # Plain image upload
+    ds_items_plain = []
+    for url in TEST_IMG_URLS:
+        ds_items_plain.append(DatasetItem(image_location=url))
+    response = dataset.append(ds_items_plain)
+    check_is_expected_response(response)
+
+    # With reference ids and metadata:
+    ds_items_with_metadata = []
+    for i, url in enumerate(TEST_IMG_URLS):
+        ds_items_with_metadata.append(DatasetItem(
+            image_location=url,
+            reference_id=Path(url).name,
+            metadata={
+                'made_with_pytest': True,
+                'example_int': i,
+                'example_str': 'hello',
+                'example_float': 0.5,
+                'example_dict': {
+                    'nested': True,
+                },
+                'example_list': ['hello', i, False],
+            }
+        ))
+
+    response = dataset.append(ds_items_with_metadata)
+    check_is_expected_response(response)