Skip to content

Commit 50f1383

Browse files
committed
fixing duplicated model reference ids
1 parent b4f740d commit 50f1383

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

tests/helpers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
PRESIGN_EXPIRY_SECONDS = 60 * 60 * 24 * 2 # 2 days
88

99
TEST_MODEL_NAME = "[PyTest] Test Model"
10-
TEST_MODEL_REFERENCE = "[PyTest] Test Model Reference" + str(time.time())
1110
TEST_MODEL_RUN = "[PyTest] Test Model Run"
1211
TEST_DATASET_NAME = "[PyTest] Test Dataset"
1312
TEST_SLICE_NAME = "[PyTest] Test Slice"

tests/test_models.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from pathlib import Path
2+
import time
23
import pytest
34
from nucleus import (
45
Dataset,
@@ -19,7 +20,6 @@
1920
)
2021
from helpers import (
2122
TEST_MODEL_NAME,
22-
TEST_MODEL_REFERENCE,
2323
TEST_MODEL_RUN,
2424
TEST_PREDS,
2525
)
@@ -46,8 +46,9 @@ def test_repr(test_object: any):
4646
def test_model_creation_and_listing(CLIENT, dataset):
4747
models_before = CLIENT.list_models()
4848

49+
model_reference = "model_" + time.time()
4950
# Creation
50-
model = CLIENT.add_model(TEST_MODEL_NAME, TEST_MODEL_REFERENCE)
51+
model = CLIENT.add_model(TEST_MODEL_NAME, model_reference)
5152
m_run = model.create_run(TEST_MODEL_RUN, dataset, TEST_PREDS)
5253
m_run.commit()
5354

tests/test_prediction.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
import pytest
2-
2+
import time
33
from helpers import (
44
TEST_DATASET_NAME,
55
TEST_MODEL_NAME,
6-
TEST_MODEL_REFERENCE,
76
TEST_MODEL_RUN,
87
TEST_IMG_URLS,
98
TEST_BOX_PREDICTIONS,
@@ -58,7 +57,7 @@ def model_run(CLIENT):
5857
assert ERROR_PAYLOAD not in response.json()
5958

6059
model = CLIENT.add_model(
61-
name=TEST_MODEL_NAME, reference_id=TEST_MODEL_REFERENCE
60+
name=TEST_MODEL_NAME, reference_id="model_" + str(time.time())
6261
)
6362

6463
run = model.create_run(name=TEST_MODEL_RUN, dataset=ds, predictions=[])

0 commit comments

Comments
 (0)